multi: Convert to use new stdaddr package. #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
changed the title
davecgh
force-pushed
the
multi_use_stdaddr
branch
4 times, most recently
from
a2e3ae1
to
d40284f
Compare
matheusd
reviewed
Mar 22, 2021
|
Changes look good so far. |
davecgh
force-pushed
the
multi_use_stdaddr
branch
2 times, most recently
from
e5e04de
to
1ace5e6
Compare
|
I've updated the various |
rstaudt2
approved these changes
Apr 3, 2021
davecgh
force-pushed
the
multi_use_stdaddr
branch
from
1ace5e6
to
f89466a
Compare
|
Builds are failing on the following commits:
There are linting errors after commit |
This modifies the test code for joining mempools and blocks to send any errors that occur over the sync channel and calling fatal in the main goroutine instead of calling fatal in the goroutines to prevent any potential teardown issues in the case of failure. This also makes go vet happy.
This converts the internal mining package to use the stdaddr package instead of dcrutil.Address as well as to support script versions. All callers that use the mining package in the repository are updated accordingly to maintain code that continues to build and work properly as well as pass all tests. In order to achieve this, it introduces temporary address conversion code that will be removed in future commits. This is part of a series of commits to convert all packages in the repository to make use of the new stdaddr package.
This converts the internal mempool package to use the stdaddr package instead of dcrutil.Address as well as to support script versions. All callers that use the mempool package in the repository are updated accordingly to maintain code that continues to build and work properly as well as pass all tests. This is part of a series of commits to convert all packages in the repository to make use of the new stdaddr package.
This converts the blockchain/stake package to use the stdaddr package instead of dcrutil.Address as well as to support script versions. All callers that use the package in the repository are updated accordingly to maintain code that continues to build and work properly as well as pass all tests. In order to achieve this, it introduces temporary address conversion code that will be removed in future commits. This is part of a series of commits to convert all packages in the repository to make use of the new stdaddr package.
This converts the blockchain/indexers package to use the stdaddr package instead of dcrutil.Address. All callers that use the package in the repository are updated accordingly to maintain code that continues to build and work properly as well as pass all tests. In order to achieve this, it introduces temporary address conversion code that will be removed in future commits. This is part of a series of commits to convert all packages in the repository to make use of the new stdaddr package.
This converts the blockchain package to use the stdaddr package instead of dcrutil.Address. All callers that use the package in the repository are updated accordingly to maintain code that continues to build and work properly as well as pass all tests. This is part of a series of commits to convert all packages in the repository to make use of the new stdaddr package.
This removes PurchaseCommitmentScript since it is no longer used by anything in the repository and is now available via the RewardCommitmentScript method of the relevant stdaddr address.
This converts the rpcclient package to use the stdaddr package instead of dcrutil.Address as well as to support script versions. All callers that use the package in the repository are updated accordingly to maintain code that continues to build and work properly as well as pass all tests. This is part of a series of commits to convert all packages in the repository to make use of the new stdaddr package.
This converts the rpcclient package to use the stdaddr package instead of dcrutil.Address as well as to support script versions. All callers that use the package in the repository are updated accordingly to maintain code that continues to build and work properly as well as pass all tests. This is part of a series of commits to convert all packages in the repository to make use of the new stdaddr package.
This converts the internal/rpcserver package to use the stdaddr package instead of dcrutil.Address as well as to support script versions. All callers that use the package in the repository are updated accordingly to maintain code that continues to build and work properly as well as pass all tests. In order to achieve this, it introduces temporary address conversion code that will be removed in future commits. This is part of a series of commits to convert all packages in the repository to make use of the new stdaddr package.
This converts the hdkeychain package example to use the stdaddr package instead of dcrutil.Address. This is part of a series of commits to convert all packages in the repository to make use of the new stdaddr package.
davecgh
force-pushed
the
multi_use_stdaddr
branch
from
f89466a
to
7b7c018
Compare
|
@matheusd Thanks for checking that! I had only tested them all as I wrote them, so I guess it must've happened in a rebase. I've resolved the build and lint issues in the first two. I think the final ones about unused code are fine since they do not result in compile errors and removing them one by one is intentional to make it easier to follow what's being removed as opposed to one big blob. |
JoeGruffins
approved these changes
Apr 12, 2021
This converts the txscript package to use the stdaddr package instead of dcrutil.Address as well as to support script versions. All callers that use the package in the repository are updated accordingly to maintain code that continues to build and work properly as well as pass all tests. In order to achieve this, some previously temporary address conversion code that is no longer needed is removed from the blockchain/indexers and internal/rpcserver packages. This is part of a series of commits to convert all packages in the repository to make use of the new stdaddr package.
This removes PayToSStx since it is no longer used by anything in the repository and is now available via the VotingRightsScript method of the relevant stdaddr addresses.
This removes PayToSStxChange since it is no longer used by anything in the repository and is now available via the StakeChangeScript method of the relevant stdaddr addresses.
This removes PayToSSGen since it is no longer used by anything in the repository and is now available via the PayVoteCommitmentScript method of the relevant stdaddr addresses.
This removes PayToSSGenSHDirect since it is no longer used by anything in the repository and is now available via the PayVoteCommitmentScript method of the relevant script hash stdaddr address.
This removes PayToSSGenPKHDirect since it is no longer used by anything in the repository and is now available via the PayVoteCommitmentScript method of the relevant pubkey hash stdaddr address.
This removes PayToSSRtx since it is no longer used by anything in the repository and is now available via the PayRevokeCommitmentScript method of the relevant stdaddr addresses.
This removes PayToSSRtxPKHDirect since it is no longer used by anything in the repository and is now available via the PayRevokeCommitmentScript method of the relevant pubkey hash stdaddr address.
This removes PayToSSRtxSHDirect since it is no longer used by anything in the repository and is now available via the PayRevokeCommitmentScript method of the relevant script hash stdaddr address.
This removes PayToAddrScript and its associated example since it is no longer used by anything in the repository and is now available via the PaymentScript method of the relevant stdaddr address.
This removes PayToScriptHashScript since it is no longer used by anything in the repository and is now available via the PaymentScript method of the relevant script hash stdaddr address.
This removes payToSchnorrPubKeyScript since it is no longer used by anything in the package and is now available via the PaymentScript method of the relevant stdaddr address.
This removes payToEdwardsPubKeyScript since it is no longer used by anything in the package and is now available via the PaymentScript method of the relevant stdaddr address.
This removes payToPubKeyScript since it is no longer used by anything in the package and is now available via the PaymentScript method of the relevant stdaddr address.
This removes payToScriptHashScript since it is no longer used by anything in the package and is now available via the PaymentScript method of the relevant stdaddr address.
This removes payToPubKeyHashSchnorrScript since it is no longer used by anything in the package and is now available via the PaymentScript method of the relevant stdaddr address.
This removes payToPubKeyHashEdwardsScript since it is no longer used by anything in the package and is now available via the PaymentScript method of the relevant stdaddr address.
This removes payToPubKeyHashScript since it is no longer used by anything in the package and is now available via the PaymentScript method of the relevant stdaddr address.
This removes GenerateSStxAddrPush since it is no longer used by anything in the repository and is now available via the RewardCommitmentScript method of the relevant stdaddr address. It also removes the associated tests and nilAddrErrStr that is no longer used upon their removal.
This removes the ErrUnsupportedAddress error kind since it is no longer needed by anything in the package.
davecgh
force-pushed
the
multi_use_stdaddr
branch
from
7b7c018
to
12c4e56
Compare
matheusd
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #2619, #2624, and #2620.
NOTE: I've left this marked as a draft for now because the variousgo.modfiles in the affected modules will need to be updated to use the latesttxscriptmodule once the aforementioned prerequisite PRs have landed to avoid issues for external consumers, however, this is otherwise ready for review.This converts all packages in the repository to make use of the new
stdaddrpackage for addresses instead ofdcrutil.Address+txscript.PayToXmethods as well as to support and make use of the script version returned by the new addresses accordingly. It also removes the aforementionedtxscript.PayToXmethods once they are no longer used.Since this involves modifications to a large number of packages in the repository, this PR is split into a series of individual commits such that everything builds and passes all tests each step of the way. In order to achieve that goal, each commit updates a single package to use the new addresses while simultaneously updating all consumers of that package in the repository to deal with any fallout of API changes. Typically, this means some temporary address conversion code is introduced and then removed in a later commit once it's no longer needed. Finally, all of the unused methods and any associated tests are then removed one by one.
See each individual commit for more details about each individual change, but the following is a high level overview:
stdaddrpackage:internal/mininginternal/mempoolblockchain/stakeblockchain/indexersblockchainblockchain/fullblocktestsblockchain/chaingenrpcclientrpctestinternal/rpcserverhdkeychaintxscriptchaingen.PurchaseCommitmentScripttxscript.PayToSStxtxscript.PayToSStxChangetxscript.PayToSSGentxscript.PayToSSGenSHDirecttxscript.PayToSSGenPKHDirecttxscript.PayToSSRtxtxscript.PayToSSRtxPKHDirecttxscript.PayToSSRtxSHDirecttxscript.PayToAddrScripttxscript.PayToScriptHashScripttxscript.payToSchnorrPubKeyScripttxscript.payToEdwardsPubKeyScripttxscript.payToPubKeyScripttxscript.payToScriptHashScripttxscript.payToPubKeyHashSchnorrScripttxscript.payToPubKeyHashEdwardsScripttxscript.payToPubKeyHashScripttxscript.GenerateSStxAddrPush