multi: Prepare for DCP0007.

[matheusd]

This PR prepares the codebase for the DCP0007 update by introducing the agenda and performing some refactorings to make the actual implementation of the consensus change clearer.

This PR is NOT intended to produce any consensus-breaking changes. This was split off from the main work towards implementing DCP0007 so that the actual consensus change that will be introduced by a future PR is more easily reviewable by other developers.

Summary of changes:

• Introduce DCP0007 related deployment and agenda
• Add functions to determine the result of the agenda vote
• Various test refactorings

[rstaudt2]

This looks good to me, I just noticed a couple of minor typos.

[JoeGruffins]

All looks right to me.

[dnldd]

Should be good after resolving @rstaudt2 review issues.

[matheusd]

Fixed @rstaudt2 review issues.

[davecgh]

This looks great overall. I've identified a few minor things inline.

[matheusd]

Squashed commits, rebased on top of latest master and fixed latest review items.

Testnet and mainnet deployments were parametrized to run over the following time span:

StartTime:  1631750400, // Sep 16th, 2021
ExpireTime: 1694822400, // Sep 16th, 2023

[davecgh]

Confirming the timestamps:

Linux:

$ date --utc --date '@1631750400'
Thu Sep 16 00:00:00 UTC 2021
$ date --utc --date '@1694822400'
Sat Sep 16 00:00:00 UTC 2023

OpenBSD:

$ date -ur 1631750400
Thu Sep 16 00:00:00 UTC 2021
$ date -ur 1694822400
Sat Sep 16 00:00:00 UTC 2023

[davecgh]

Updates look good. I did spot that the vote was note added to blockchain/fullblocktests/params.go as well. I typically add it there too because those parameters are used in the regression tests and if it hits a path where the deployment is expected to exist, but doesn't, it'll fail unexpectedly.

[matheusd]

Added to fullblocktests/params.go. Also added the description to the agenda, which as missing.

[davecgh]

Added to fullblocktests/params.go. Also added the description to the agenda, which as missing.

Nice. I noticed the description myself earlier when going over it again, but hadn't commented yet as I was waiting to finish another round of review.

[davecgh]

I've given this another round of review and don't see any other issues.

I also modified wallet locally to pull in the latest chaincfg dev module and bump the vote version to ensure things are showing up properly there as well:

$ ./ctl getvotechoices
{
  "version": 10,
  "choices": [
    {
      "agendaid": "reverttreasurypolicy",
      "agendadescription": "Change maximum treasury expenditure policy as defined in DCP0007",
      "choiceid": "abstain",
      "choicedescription": "abstain voting for change"
    }
  ]
}

[davecgh]

Also, simnet results of getvoteinfo for reference:

$ ./ctl getvoteinfo 10
{
  "currentheight": 32,
  "startheight": 144,
  "endheight": 463,
  "hash": "03cb3fb5bac92824e20efd6856c3955881e75e584a57951cdbe21b195889ff0f",
  "voteversion": 10,
  "quorum": 160,
  "totalvotes": 0,
  "agendas": [
    {
      "id": "reverttreasurypolicy",
      "description": "Change maximum treasury expenditure policy as defined in DCP0007",
      "mask": 6,
      "starttime": 0,
      "expiretime": 9223372036854775807,
      "status": "defined",
      "quorumprogress": 0,
      "choices": [
        {
          "id": "abstain",
          "description": "abstain voting for change",
          "bits": 0,
          "isabstain": true,
          "isno": false,
          "count": 0,
          "progress": 0
        },
        {
          "id": "no",
          "description": "keep the existing consensus rules",
          "bits": 2,
          "isabstain": false,
          "isno": true,
          "count": 0,
          "progress": 0
        },
        {
          "id": "yes",
          "description": "change to the new consensus rules",
          "bits": 4,
          "isabstain": false,
          "isno": false,
          "count": 0,
          "progress": 0
        }
      ]
    }
  ]
}