config: Add logsize config option. #2711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
reviewed
Aug 23, 2021
|
yeah, i had mentioned that to @davecgh in another chat. there's already no option for the logdir, so i wasn't sure if we cared to include that and/or this. probably makes the most sense to hit them both up in a later PR if we do want them. |
matheusd
approved these changes
Aug 23, 2021
|
Is it really worth adding the extra code to support handling this as a string? Especially considering all of that code is duplicated across dcrd and dcrwallet? I added this same functionality in decred/vspd#249 and just made the param an integer which is always measured in MB. |
|
When people want their logs to grow to the gigabytes, yes... |
|
If somebody wants 2GB they can simply set |
|
2048, actually. |
JoeGruffins
approved these changes
Aug 26, 2021
davecgh
reviewed
Aug 27, 2021
The logsize option enables configuration of the currently-hardcoded value of 10MiB log files before they are rotated and compressed. The default remains 10MiB. This is a string option and requires using a suffix such as K, M, or G to specify the units as kibibytes, mebibytes, or gibibytes.
davecgh
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logsize option enables configuration of the currently-hardcoded
value of 10MB log files before they are rotated and compressed. The
default remains 10MB.
This is a string option and requires using a suffix such as KB, MB, or
GB to specify the units as kibibytes, mebibytes, or gibibytes.