mempool: Accept expired prune height. #3042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the method that prunes expired transactions to accept the current best height as opposed to looking it up internally. While this change doesn't really have any effect in isolation, it is part of an ongoing effort to make the internal mempool state easier to reason about for correctness by removing hidden assumptions. In this particular case, it removes the reliance on the assumption that the tip of the chain has not changed as compared to what the caller expects it to be.
dajohi
approved these changes
Jan 9, 2023
dnldd
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the method that prunes expired transactions to accept the current best height as opposed to looking it up internally.
While this change doesn't really have any effect in isolation, it is part of an ongoing effort to make the internal mempool state easier to reason about for correctness by removing hidden assumptions. In this particular case, it removes the reliance on the assumption that the tip of the chain has not changed as compared to what the caller expects it to be.