blockchain: Reject params with shared mask bits. #3077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
added
the
test coverage
dajohi
approved these changes
Mar 10, 2023
This introduces a helper func to the tests that updates the masks and choice bits for all votes in a provided test agenda so that they are non-overlapping. It then updates a couple of the tests that merge votes into the same agenda to make use of the func so they no longer involve overlapping bits.
This adds an additional validation check to the chain initialization process to validate that the masks of votes in the same deployment versions in the given chain params do not have any shared bits. It also adds a test for the new validation logic.
davecgh
force-pushed
the
blockchain_reject_params_with_shared_mask_bits
branch
from
1f7930a
to
491d178
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #3076.This adds an additional validation check to the chain initialization process to validate that the masks of votes in the same deployment versions in the given chain params do not have any shared bits along with a test for the new validation logic.
Since some of the tests violate this condition, it also introduces a helper func to the tests that updates the masks and choice bits for all votes in a provided test agenda so that they are non-overlapping and then updates a couple of the tests that merge votes into the same agenda to make use of the func so they no longer involve overlapping bits.