Merge in btcd commit 27c0f9f8d1af6a44423b03a2e4f03d4a87a1ac40 #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the root field and all references to it from the BlockChain since it is no longer required. It was previously required because the chain state was not initialized when the instance was created. However, that is no longer the case, so there is no reason to keep it around any longer.
This adds a benchmark for deserializing a large transaction that is often referred to as the megatransaction since it is the largest Bitcoin transaction mined to date. It consists of 5569 inputs and 1 output and its hash is: bb41a757f405890fb0f5856228e23b715702d714d59bf2b1feb70d8b2b4e3e08. This is being done so there is a benchmark that tests more of a worst-case scenario which is a better candidate for identifying and testing improvements. The following benchmark results shows the how much more intensive this transaction is over the existing mock transaction: DeserializeTxSmall 1000000 1751 ns/op 376 B/op 16 allocs/op DeserializeTxLarge 300 5093980 ns/op 1672829 B/op 33430 allocs/op
Merges in btcd commit de4fb24.
Merges in btcd commit 27c0f9f.
alexlyp
approved these changes
Sep 23, 2016
|
go test PASSES |
|
go test -bench=. -benchmem=true |
davecgh
approved these changes
Sep 23, 2016
There was a problem hiding this comment.
This obviously had to be changed versus the upstream test since Decred has a different transaction format, but I sort of doubt this new benchmark as written is very indicative of an actual large transaction due to the fact it's just repeating the same bytes. As a result, the cache will get loaded up versus a real mega transaction like the upstream test has.
That said, it's still better than nothing, so OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges in btcd commit 27c0f9f. Generates its own large transaction rather than uses a pregenerated one, saving space and becoming platform independent.