Fix the dumpblockchain function #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please change the description in config.go to match? Maybe something like "Write blockchain in addblock format to the specified file" |
The dumpblockchain function used to serialize a map of block into gob serialized format, which was used for testing but which was incompatible with the addblock tool. The function now dumps a flat file the the same format required by the addblock tool. A couple shutdown assertions were added as well, to prevent potential panics if pointers were nil. The duration of time it took to sync the blockchain with addblock is now reported.
cjepson
force-pushed
the
cj_061216dumpblockchain
branch
from
8f32861
to
0f1ac45
Compare
|
@jolan Fixed |
jolan
approved these changes
Oct 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dumpblockchain function used to serialize a map of block
into gob serialized format, which was used for testing but which
was incompatible with the addblock tool. The function now dumps
a flat file the the same format required by the addblock tool.
A couple shutdown assertions were added as well, to prevent
potential panics if pointers were nil. The duration of time
it took to sync the blockchain with addblock is now
reported.