fullblocktests: Limit tickets to target pool size. #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the full block consensus tests to only purchase tickets until the target pool size is reached during the initial creation of the blocks needed to reach stake validation height. This helps make the code a little more flexible since it will allow many more blocks to be created without spiking the ticket price as would happen prior to this change. For a little intuition, once stake validation height is reached the tests intentionally purchase the same number of tickets as are voting on each block in order to achieve a steady state, so if the number of tickets in the pool are already higher than the target pool size prior to reaching that steady state, the ticket price would keep rising until the outputs used to purchase the tickets no longer had enough funds available to purchase them.
marcopeereboom
approved these changes
Dec 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the full block consensus tests to only purchase tickets until the target pool size is reached during the initial creation of the blocks needed to reach stake validation height.
This helps make the code a little more flexible since it will allow many more blocks to be created without spiking the ticket price as would happen prior to this change.
For a little intuition, once stake validation height is reached the tests intentionally purchase the same number of tickets as are voting on each block in order to achieve a steady state, so if the number of
tickets in the pool are already higher than the target pool size prior to reaching that steady state, the ticket price would keep rising until the outputs used to purchase the tickets no longer had enough funds
available to purchase them.