Implement stake voter version interrogation command. #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcopeereboom
force-pushed
the
stakeversion_rpc
branch
from
86375d2
to
5864db8
Compare
alexlyp
reviewed
Dec 22, 2016
| // | ||
| // This function MUST be called with the chain state lock held (for writes). | ||
| func (b *BlockChain) findNode(nodeHash *chainhash.Hash) (*blockNode, error) { | ||
| func (b *BlockChain) findNode(nodeHash *chainhash.Hash, searchDepth int) (*blockNode, error) { |
There was a problem hiding this comment.
why are you adding searchDepth arg here?
There was a problem hiding this comment.
Because one may be looking for the stats of block 12 while the chain is at 90000.
There was a problem hiding this comment.
OK, with added explanation in PR
alexlyp
approved these changes
Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement dcrctl getstakeversions command. This PR also expands the findNode command to search arbitrary depths but maintains backwards compat by implementing the prior 2800 depth max constant.
Example: dcrctl getstakeversions $(dcrctl getbestblockhash) 10
returns the last 10 stake/voter versions stats.
Fixes #521