Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcserver: Disable getblocktemplate. #672

Merged
merged 1 commit into from
Apr 28, 2017

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Apr 28, 2017

This disables the getblocktemplate RPC handler since it does not at all work as intended. Fixing it is going to be a larger effort, so just disable it until it can be properly implemented.

Copy link
Member

@dajohi dajohi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK as getblocktemplate is not ready.

@davecgh davecgh added this to the v1.0.1 milestone Apr 28, 2017
This disables the getblocktemplate RPC handler since it does not at all
work as intended.  Fixing it is going to be a larger effort, so just
disable it until it can be properly implemented.
@davecgh davecgh force-pushed the disable_getblocktemplate branch 2 times, most recently from c070743 to 2dfb055 Compare April 28, 2017 16:15
@davecgh davecgh merged commit 2dfb055 into decred:master Apr 28, 2017
@crackfoo
Copy link

well, shouldn't you spend the time to fix this?

@davecgh davecgh deleted the disable_getblocktemplate branch April 29, 2017 21:26
@davecgh
Copy link
Member Author

davecgh commented Apr 29, 2017

@crackfoo: Of course. The description says exactly that!

Fixing it is going to be a larger effort, so just disable it until it can be properly implemented.

Also, it is important to note that Decred miners use getwork anyways because it is the preferred method in Decred. Unlike other coins, Decred provides additional space in the header itself which negates the primary reason getwork was deprecated to begin with, which is that it was unable to serve work quickly enough to fast miners.

Also, miners are able to start solving the blocks more quickly with getwork in Decred over getblocktemplate too since it's less data across the wire, which means more profit for them.

@detailyang
Copy link
Contributor

@davecgh when it will be fixing ?

We're implementing the decred POW pool by getblocktemplate.
Do you have any idea ? Many thanks:)

@detailyang
Copy link
Contributor

never mind, we got it by getwork:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants