chainstate only needs the previous block hash #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
changed the title
davecgh
requested changes
Jun 21, 2017
There was a problem hiding this comment.
Concept ACK.
I think the name should probably be BestPrevHash instead of BestPrevBlock since the latter seems to imply it's the entire block. I know the header field is actually named PrevBlock (and it probably should've been PrevBlockHash or PrevHash honestly, but that ship has sailed). However, in the case of the header, it is already well known that it's just a hash. In the case of chain, it often deals with actual blocks.
... not the entire block header.
|
updated |
jolan
reviewed
Jun 21, 2017
davecgh
approved these changes
Jun 21, 2017
davecgh
added a commit
that referenced
this pull request
Aug 2, 2017
As noted in issue #706, the existing code had an issue where the normalized result was > P when both the first and second words of the field representation being normalized were BOTH greater than or equal to the first and second words of P. Although this condition is rare in practice, it needs to be handled properly. This resolves the issue by comparing the low words in the final reduction step against the normalized low order prime bits to ensure the final subtraction occurs correctly any time they're > P. This approach retains the constant time property as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... not the entire block header.