peer: Strictly enforce bloom filter service bit. #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the enforcement of the bloom filter service bit much more strict. In particular, it does the following: - Moves the enforcement of the bloom filter service bit out of the peer package and into the server so the server can ban as necessary - Disconnect peers that send filter commands when the server is configured to disable them regardless of the protocol version - Bans peers that are a high enough protocol version that they are supposed to observe the service bit is disabled, but ignore it and send filter commands regardless. As an added bonus, this fixes the old logic which had a bug in that it was examining the *remote* peer's supported services in order to choose whether or not to disconnect instead of the *local* server's supported services.
Upstream commit 8965d88.
dajohi
reviewed
Jul 27, 2017
| // whether or not banning is enabled, it is checked here as well | ||
| // to ensure the violation is logged and the peer is | ||
| // disconnected regardless. | ||
| if sp.ProtocolVersion() >= wire.BIP0111Version && |
There was a problem hiding this comment.
I wonder if a whitelisted check should go here... (&& !sp.isWhitelisted)
There was a problem hiding this comment.
I would prefer that go into a separate PR, if we even want it at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream commit 8965d88.
This makes the enforcement of the bloom filter service bit much more strict. In particular, it does the following:
peerpackage and into the server so the server can ban as necessaryAs an added bonus, this fixes the old logic which had a bug in that it was examining the remote peer's supported services in order to choose whether or not to disconnect instead of the local server's supported services.