Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txscript: Correct p2sh hashes in json test data. #785

Merged

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Aug 3, 2017

This corrects the hashes for the p2sh scripts in the invalid transaction JSON data. This helps ensure the transactions are failing for the intended reason as opposed to the p2sh script never being run
because the script hashes don't match.

Copy link
Member

@dajohi dajohi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

This corrects the hashes for the p2sh scripts in the invalid transaction
JSON data.  This helps ensure the transactions are failing for the
intended reason as opposed to the p2sh script never being run because
the script hashes don't match.
@davecgh davecgh force-pushed the txscript_test_data_proper_p2sh_hashes branch from fd98028 to c11117a Compare August 3, 2017 16:21
@davecgh davecgh merged commit c11117a into decred:master Aug 3, 2017
@davecgh davecgh deleted the txscript_test_data_proper_p2sh_hashes branch August 3, 2017 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants