Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dcrjson: add ticket fee field to PurchaseTicketCmd. #902

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

dnldd
Copy link
Member

@dnldd dnldd commented Oct 14, 2017

No description provided.

@davecgh
Copy link
Member

davecgh commented Oct 18, 2017

This is going to require a rebase since it conflicts. Also, why is this field required? The fee is already known to the code and is applied accordingly. There is already a spendLimit parameter which limits how much will be paid for the ticket.

@dnldd
Copy link
Member Author

dnldd commented Oct 18, 2017

the field allows overriding computed ticket fees with a custom value, see decred/dcrwallet#406

@dnldd dnldd closed this Oct 18, 2017
@dnldd dnldd reopened this Oct 18, 2017
@davecgh
Copy link
Member

davecgh commented Oct 18, 2017

I'll take a look, but this doesn't really feel like the correct place for such a thing. I'm pretty sure the only reason this RPC exists in drcd to begin with is to make use of the current ticket price. If the goal is to simply create custom tickets, I really don't think that belongs here.

@davecgh
Copy link
Member

davecgh commented Oct 22, 2017

After discussing this offline and looking again, its intent is to allow the transaction fee on the ticket purchases to be specified directly as opposed to the ticket purchase price as I commented above. I have no objections to allowing the transaction fee on the ticket to be specified as a part of this call.

@davecgh davecgh merged commit 70bdae7 into decred:master Jan 29, 2018
@dnldd dnldd deleted the ticketfee branch February 5, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants