-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Politeia UI/UX coordination - master issue #77
Comments
@marcopeereboom would have to weigh in on the future development plans as he's managing the project. I personally would like to scrap the reddit design and start from the ground up, but I'm not sure if Marco wants to refactor and improve the server-side first, or if he even wants to move in that direction. |
I think this is a much valuable discussion and Pi deserves this UI/UX attention to keep the high quality of Decred products design. Mobile-friendly version #162 |
Here's an outline of major flows, and also pages and elements currently in Politeia: Flows
Pages
Page-Independent UI Elements
|
@linnutee we will get on top of it following Monday and try to add more people from our side to work on this issue. |
Pi logo in color: #83 |
Proposal cards' visual design improvement+indicating proposal vote success/failure XD files: Proposal cards. 15.01.19.zip |
Display live Treasury wallet data XD file: Treasure wallet data.zip |
Main redesigned Pi pages XD file: Politeia_18.01.19.zip |
Highlight comments since last visit XD file: Comments 15.09.19.zip |
Pagination for proposal credit table XD file: Account history_18.01.19.zip |
This master issue looks pretty good in regards to covering all the different workflows / UI views. I went through the GUI issues and found this one was the only one missing from the list |
Draft placeholder for onboarding visuals |
Show history for single proposal XD file: Actions history_24.01.19.zip |
I really liked the slides I saw with the redesign and I see no reason not to move forward with it. CMS is getting to a point that it works well enough which will free up some front-end guys. I believe that the way we should develop this is by having two teams. Team one deals with maintaining current Pi and we will focus on actual issues only and not develop any new GUI things. Team two starts the work on the redesigned website. I also believe that the newly designed website needs to be put up as quickly as possible in case the backend has to support additional things. As it stands the API is a bit too big IMO and I would like to deprecate several routes. The one thing I think we need to do with the new site is to make it responsive. I wrote a websocket framework and we should articulate what needs to be handled using REST and what needs to be handled using websockets. If everyone agrees I will formally assign people and start driving this effort. |
I have a repo to create a library for the new design (it will replace snew-classic-ui components with a more loose coupling approach). |
Expanding the idea of having two teams to get the new design out of the paper, I propose the following if everyone agrees:
Once the new design work has evolved we start migrating ppl from Team politeiagui to help Team redesign to wrap up the website and delivery it to the first testnet try. This is the first sketch, of course, can be reviewed at any time. |
I really like this approach for the redesign. Splitting us into teams will make everything flow a lot smoother as we won't be having to bounce back and forth between projects. I agree with @fernandoabolafio's proposed teams as well unless @marcopeereboom or anyone else has issues with it. Among other things, the decoupling of snew is going to require some extensive experience with the library which I think Tiago and Fernando have the most of My only suggestion for now would be to go through all the issues and label them by team accordingly |
I think we need at least one more experienced person on team pigui. |
I like the approach of having two teams to kickstart the new design. @fernandoabolafio's suggestion makes sense to me, since integrating the new ui and decoupling from snew will need more experienced eyes on the task. I think we in the proposed team pgui can handle the upcoming bugs and maintenance of the code, since we recently knocked out more important issues. @marcopeereboom did a great cleanup on the issue list already, but it would be nice to go with @camus-code suggestion and go through it one more time and label them by team as well. |
I won't abandon team pgui, I will be reviewing PRs, managing issues, etc. Just for coding, I will be more devoted to the new design. This integration requires lots of code tweaks to make sure will have not only a new design but as well a better code structure to speed up the development of new features after it. |
If we have something that is ready enough to be seen we need to get this up. @dajohi can add a beta-testnetproposals.decred.org vm for this. We should probably automate deployment on it so that it is always current. |
Part of the redesign is that we are going to replace all pages that don't strictly require JS with server-side rendered HTML. @linnutee I wanted to make sure that you are aware of this. |
From the UI's perspective, we can build the JS/Non-JS versions in JS and add a component to specifically exclude parts of the app that are not applicable for non-js users (like login and other forms) So from @linnutee we mostly will need highlighting of what elements should be excluded when JS is not available, and any additional messaging we want to show when that is the case. |
Well, formed the new list of tasks concerning Pi redesign: Desktop views
Responsive views
|
@MariaPleshkova can you add a few more items to that list?
Update:
|
In continuation of decred/politeiagui#843, I realized I can just nuke the sidebar with a simple CSS filter and it feels so much better. |
@MariaPleshkova I noticed that there isn't a Edit1:
|
Preview for redesigned Pi screens: https://xd.adobe.com/view/a6a62142-18c9-4d0c-4ebd-0fcdec0390ad-d097/ Specs: https://xd.adobe.com/spec/25f9f648-8d13-446f-75aa-242b21116f87-53c8/ I've updated some things there (added filter with categories to proposals, added categories to create proposal screen, some updates to comments view (name in replies highlighted with yellow is the name of proposal's author) ), changed font sizes (now they are 28,24,16,13 px), removed Segoe font (it was a bug), added some icons in front of titles, added grid to all the pages and created responsive screens. @tiagoalvesdulce 's and @fernandoabolafio 's above comments are in process. I'll send an updated preview as soon as they are done. |
@MariaPleshkova after reviewing the new preview I have a few comments:
Selector: Collapsable menu:
|
@MariaPleshkova we also need a tab for the user preferences in the user details page. Here is how it looks in pi right now: |
@tiagoalvesdulce ok, got you |
@MariaPleshkova 2: I am very convinced that we can find a better component than tabs to represent the categories filter. Especially because they are filters, so you should be able, for example, to combine "Development" and "Marketing", tabs are more suited to situations where the options are mutually exclusive. 3: since you like it the 1st sight, we will proceed using the "full view" modal for mobile screens for now. You can test in a variety of screens and see how it feels to you. It's easier to reduce its size later on if you think it's better. |
1 + 2. Rule of thumb for the tabs could be that if they can fit in mobile – do show all of them. Ie. under user profile, there's only three – so it's more clearer to show all. User can tell right off that we're dealing with navigation. Do agree on the proposals page (and other instances if there's any) where we got the dual filtering (by proposal status + category/type) basically. In that instance the adapted component can be some sort of a drop-down or expandable element. Rough example, do improve the visual design – maybe can find some way to make it more relatable to the desktop navigation … e.g. using the yellow underline differently. |
Closing this one down. @MariaPleshkova please note down any referred outstanding issues to the Board when addressing. I will do the same. https://github.com/decred/dcrdesign/projects/4 can be the main source for tracking those then. |
Several of my issues to improve UX were closed as "part of redesign". I suggest to close such issues only when the redesign is released. For devs and designers, it's easier to miss things when they are not in open issues. For the submitter, it cuts the way to follow when his issue will be really resolved. Specific example: #840 was closed with "part of #77". Ok I open #77... it is now closed. Where should I follow next? I hope it illustrates my point. |
Issues are closed as they merged into master, not when they are deployed to production. |
Creating this as a master issue to help coordinate Politeia related UX/UI design work. This includes a higher level perspective on what's what, an ordered list of tasks as well cross-references to open issues and requests worth covering in the /politeiagui repo.
For bit of background information – although I've not been involved with Pi developments presently, i've helped with desiging the initial reddit based prototype version of Pi. Keeping in mind an important aspect that any large scale design updates are likely not worth the wrestle for now (with reddit's framework). For that reason the current product should be treated as a hi-fi prototype that assures: keeping up a general visual hygiene; logical and simple interaction solutions for Politeias features. Both of these aspects should keep in mind Reddits framework constraints and be approached in a way feasible to implement. Any feedback from front-end devs currently working on this is much welcomed.
I will not cover any issues that to my knowledge require completely replaying any larger interaction flows, structural designs or implementing a full set of new assets/patterns. Rather the goal is to tweak up this current builds UI design to a bit more consistent and improved quality levels.
Regarding these limitations, would like to hear perspectives from @sndurkin and @marcopeereboom around the development plans. Last time I brought this topic up it wasn't clear when this reddit-based build could be dropped and the design and front-end to be re-created from the ground up. Asking this as it's worth to notice this will serve as an excellent new project for growing the design discipline. I would expect the scope for ground-up work to require involvement of at least 2-3 interaction and visual designers as well the front-end developers. This is either opportunity to b42 to get more involved in DCR as well for new individuals or a small UI/UX studio to get involved.
Tasks:
If not present, please create separate issues to the new tasks when taken on.
Identity: define and implement color scheme (@saender, @MariaPleshkova)
Politeia as a product has it's own iterated logo that relates strongly (ambigram construction) to DCR brands ecosystem. Similarly the color scheme should have it's own take. I think it shouldn't be too far off from Decred color scheme, but with some clear distinguishability and potentially a new key colour. This needs input from @saender or should be collaborated with him, as he authored the Pi logo and is most relevant person on the identity subject.
Once a color scheme is established, all non-relevant colors should be replaced in the UI. This will create a cleaner and more consistent template overall. At the moment there is no consistency between the DCR color scheme and various reddit framework colors.
Deliverable: color applied to key views; element-, or view-based design examples prepared for front-end implementation.
Onboarding illustrations (EETER, Kyle, 30000fps)
There are some illustration and motion design assets in the pipeline to improve Pi's onboarding and communications. These are essentially character designs, adding more meaning to the current textual bits. Temporarily on-hold.
Map out spacing and layout issues (@MariaPleshkova)
Fundamental visual design task to improve general visibility and design quality. First goal should be ironing out any really obvious spacing and positioning related issues.
Map out typography issues (@MariaPleshkova)
This should aim to establish a good baseline type practice, improve legibility and communicate hierarchies.
Map out relevant locations for icons (@MariaPleshkova)
Where it helps to communicate meaning and feedback and guide the user. Use Decred's extensive iconography, no reason to develop new.
Map out interaction issues (@MariaPleshkova, @linnutee )
Larger task that requires some testing, either done by the designer/researcher or small scale qualitative user tests to locate any critical issues. I'd recommend limiting the scope to the following (or less): discoverability related issues, feedback and signifiers, patterns similarities and consistency, relations between controls mappings and constraints.
Map out copywriting issues (…)
Similarily as other design items, the copy needs to be consistent through-out various touchpoints. Function related copy items needs to be clear, considerate and useful for the user. Write them short, then cut in half and remove jargon.
Improve visual design of proposal cards (@MariaPleshkova)
This is one key element that can be further refined. Recently there was a PR that implemented displaying quorum decred/politeiagui#821, so the progress bars, way quorum is displayed and other related elements can be in better relation to Decrediton. Also should keep in mind how to distinguish the different proposal states as well #611 below.
Open issues in Pi repo:
Clearly indicate proposal vote success or failure (@MariaPleshkova)
decred/politeiagui#611
Important issue addressing feedback aspect. Should be kept somewhat similar as how the function is solved in Decrediton (https://xd.adobe.com/view/9fdb7614-cff0-4972-6e72-2ab1d40b5482-e9ea/screen/dbfcc3cf-27c2-4b5d-935c-d825ded80fff/Governance-Proposals-Under-Vote) and voting.decred.org
Feature request: Notifications (@MariaPleshkova)
decred/politeiagui#728
Comes down to setting up a baseline notifications system. Both UI and in mail. Concept design examples.
Feature Request: Highlight new comments since last visit (@MariaPleshkova)
decred/politeiagui#732
Should have some relation to reddit.
Minor: improve formatting of Marketing example in the proposal guidelines tab (@MariaPleshkova)
decred/politeiagui#689
Relates to typography in general.
Display live Treasury wallet data (@MariaPleshkova)
decred/politeiagui#672
Can consider displaying this content within the footer.
Pagination for proposal credit table (@MariaPleshkova)
decred/politeiagui#615
Less important, enhancement.
Global Activity page (feed) #783 (@MariaPleshkova)decred/politeiagui#783
Not sure if this is technically feasible, feedback from devs needed. If it is, certainly good UX enhancement, would need quick design prototype to start with.
The work will be mostly covered by @MariaPleshkova and @nick7000 from b42 and assisted by EETER when needed.
The text was updated successfully, but these errors were encountered: