core: handle epoch order messages. #188
Conversation
This updates the epoch queue to track the current epoch and implements the associated epoch order handler.
dnldd
force-pushed
the
handle_epoch_order
branch
from
f3248bf
to
aaec0db
Compare
client/core/core.go
Outdated
| match := false | ||
| for _, mkt := range dc.markets { | ||
| if mkt.Display() == note.MarketID { | ||
| match = true |
There was a problem hiding this comment.
Could just return here and get rid of the match variable. Regarding it being an error, let me see if I understand: If Core is only setup for market X, but messages for market Y come in, that means the client has somehow registered on the orderbook route (which include the epoch order notes) for market Y or the server is misbehaving and sending messages that weren't what the client registered for. Does that sound right? In the first case, that's clearly an Core error, but in the second that's the server messing up.
There was a problem hiding this comment.
I'd say both cases outlined apply, and they're both errors, no?
There was a problem hiding this comment.
I should be breaking after setting match however.
There was a problem hiding this comment.
Oh, right, the check below is for !match.
There was a problem hiding this comment.
updated the commit, would like to squash it if it's all good now.
There was a problem hiding this comment.
TBH, I prefer not squashing until the review is approved, if at all. It helps reviewers follow changes, and github squashes for us on merge.
I just remove commit descriptions that don't describe a net effect of the PR, although I welcome squash commit messages in comments.
dnldd
force-pushed
the
handle_epoch_order
branch
from
fa20c3f
to
f8579cd
Compare
dnldd
force-pushed
the
handle_epoch_order
branch
from
f8579cd
to
76406db
Compare
This adds the
epoch_ordernotification handler to the client core.