client/asset/eth: break immediately on shutdown when timing out #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
commented
Feb 28, 2023
| func (eth *ETHWallet) checkForNewBlocks(reportErr func(error)) { | ||
| ctx, cancel := context.WithTimeout(eth.ctx, 2*time.Second) | ||
| func (eth *ETHWallet) checkForNewBlocks(ctx context.Context, reportErr func(error)) { | ||
| ctx, cancel := context.WithTimeout(ctx, 2*time.Second) |
There was a problem hiding this comment.
Same actual context, but I we're moving toward best practices.
buck54321
approved these changes
Feb 28, 2023
JoeGruffins
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2045
Turns out the timeouts there before shutdown were (wait for it)... DNS. The only actual issue there was that shutting down when
eth.checkForNewBlockswas timing out would involve a random chance of receiving from the canceled context instead of the ticker.This change checks for a shutdown that may have occurred while
eth.checkForNewBlockstimed out. I've decided to keep the ticker because with health providers, it is desirable to keep a regular check interval in terms of wall time rather than relative to the previous check. Tickers don't backup indefinitely, but they will buffer a single tick, so a single tick may be delayed when there is a timeout.