server: add order router #65
Conversation
The order router routes market, limit, and cancel orders to waiting markets, performing validation and type translation along the way. To accommodate the needs of the order router, two new methods were added to common types from the asset package. asset.UTXO got a value getter, and asset.DEXAsset got a method to validate addresses.
| // Check that the outpoint isn't locked. | ||
| locked := tunnel.OutpointLocked(txid, utxo.Vout) | ||
| if locked { | ||
| return errSet(msgjson.FundingError, | ||
| fmt.Sprintf("utxo %s:%d is locked", utxo.TxID.String(), utxo.Vout)) | ||
| } |
There was a problem hiding this comment.
OutpointLocked could be made to return more details. What would be helpful here? Locked by another order X?
There was a problem hiding this comment.
Could be a funding UTXO in an epoch order, and order book order, or any order with an active match. This check could also be handled by storage, since it's all tracked there too.
buck54321
force-pushed
the
otherrouter
branch
from
3cb5e8a
to
988838d
Compare
buck54321
force-pushed
the
otherrouter
branch
from
988838d
to
b44f709
Compare
| tunnel.SubmitOrderAsync(oRecord) | ||
| r.respondOrder(oRecord) |
There was a problem hiding this comment.
I've separated the signing/response from the epoch submission, but if we move this respondOrder method to Market and do it in the main loop, that will solve the epoch synchronization issue.
There was a problem hiding this comment.
Presently, Market has access to the auth manager via the swapper, so it can implement respondOrder. Let's try that.
There was a problem hiding this comment.
If Market is dealing with authenticated messages, it might as well have it's own copy of AuthManager.
| type MarketTunnel interface { | ||
| // SubmitOrderAsync submits the order to the market for insertion into the | ||
| // epoch queue. | ||
| SubmitOrderAsync(*orderRecord) |
There was a problem hiding this comment.
See comments below about respondOrder, but using this new orderRecord wrapper in anticipation of moving server time stamping to the Market mainloop.
server/market/orderrouter.go
Outdated
| } | ||
| respMsg, err := msgjson.NewResponse(oRecord.msgID, res, nil) | ||
| if err != nil { | ||
| log.Errorf("failed to create msgjson.Message for 'cancel' response: %v", err) |
|
I'm comfortable merging this when you're ready, @buck54321. We're going to need to iterate on a bunch of things, but having it in will help move things only in my work. |
The order router routes market, limit, and cancel orders to waiting markets, performing validation and type translation along the way.
To accommodate the needs of the order router, two new methods were added to common types from the asset package. asset.UTXO got a value getter, and asset.DEXAsset got a method to validate addresses.
Resolves #52