Update most dcrd packages #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
reviewed
Jul 21, 2020
davecgh
reviewed
Jul 22, 2020
This fixes the ComputePkScript function to check for the correct minimum and maximum lenghts of a DER-encoded signature.
davecgh
approved these changes
Jul 22, 2020
fguisso
reviewed
Jul 22, 2020
| @@ -21,14 +21,14 @@ import ( | |||
| ) | |||
|
|
|||
| var ( | |||
| localPrivkey = []byte{1, 2, 3, 4, 5, 6} | |||
| remotePrivkey = []byte{6, 5, 4, 3, 2, 1} | |||
| localPrivkey = []byte{1, 2, 3, 4, 5, 6} //nolint:unused | |||
There was a problem hiding this comment.
Due to the t.Skipf() in tests the linter (correctly) assumes the lines of code where these variables are used are never reached, so it complains about them being unused.
This updates the dcrd packages to their latest version in the app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates most dcrd packages to their latest versions.
While there, it also pushes a fix that should have landed in the previous upstream merge pr for the chainscan package.