Switch to wallet-backed chain io in dcrlnd #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
force-pushed
the
wallet-chainio
branch
3 times, most recently
from
a984811
to
935b74e
Compare
This introduces an implementation of the lnwallet.BlockchainIO interface via the Dcrwallet driver used with embedded-wallet dcrlnd instances. This allows the wallet driver to be used for all blockchain-related operations, removing the need for a direct connection between dcrlnd and a dcrd instance. This is work towards eventually supporting an SPV mode in dcrlnd.
This introduces an implementation of the lnwallet.BlockchainIO interface via the RemoteDcrwallet driver used in remote wallet dcrlnd instances. This allows the wallet driver to be used for all blockchain-related operations, removing the need for a direct connection to a dcrd instance. This is work towards supporting an SPV mode in dcrlnd.
This changes the root dcrlnd package to allow using the wallet as source
for chain data.
For remote wallets, the node is changed to unconditionally use the
wallet instead of relying on a dcrd connection.
For embedded wallets, a new node option is added ("dcrw") which
specifies if the node will use the wallet as the source for chain
operations.
The intention is to eventually phase out the old "dcrd" node connection
mode, but that is not done in this commit so that we can maintain the
legacy mode for comparison and testing.
The Github Actions CI script has been changed to test both the old
("dcrd") connection mode and the new ("dcrw") connection modes so we can
ensure the new mode is working correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on top of #93
Part of #80
This switches the main dcrlnd package to use the recently introduced wallet-backed drivers for chain IO operations.
The net result is that chain IO operations are now fully performed by the underlying dcrwallet instance and dcrlnd no longer requires a connection to a running dcrd to perform its job.
For dcrlnd operating in remote wallet mode (such as those running from within Decrediton) the change is automatic.
For dcrlnd operating with an embedded dcrwallet, a new value for the
nodeconfig option (dcrw) must be specified to use the new IO mode. Both the olddcrdmode and thedcrwmode are tested via itests running in the Github Actions CI.