pool: decouple components. #143
Conversation
This updates the client hash calculation threshold to 30 seconds. Tests have also been added for the various client processes.
dnldd
force-pushed
the
decouple_components
branch
from
6ac8118
to
c8c9c31
Compare
This reactors functionality from various structs namely shares, db, hub and payments. This also fixes lint related issues.
dnldd
force-pushed
the
decouple_components
branch
from
c13a97e
to
8fd7900
Compare
There was a problem hiding this comment.
I've reviewed this and dropped some comments, but I cannot make any promises about the completeness of the review. This is a massive changeset and was very painful to review.
Please consider breaking future changes into multiple, smaller PRs for ease of reviewing and to reduce likelihood of defects sneaking through.
Also, please do not rebase/squash/force-push this PR, because it will make reviewing further changes even more painful.
|
Hmm, I mostly split the commits based on the introduced component or its associated tests. I'm curious to know what made reviewing each commit difficult. |
This simplifies payment requests by only requiring the address of an account instead of an account id.
pool/paymentmgr.go
Outdated
| // addPaymentRequest creates a payment request from the provided account | ||
| // if not already requested. | ||
| func (pm *PaymentMgr) addPaymentRequest(addr string) error { | ||
| _, err := dcrutil.DecodeAddress(addr, pm.cfg.ActiveNet) |
There was a problem hiding this comment.
There are three places where Account() is preceeded by a call to DecodeAddress().
Perhaps DecodeAddress can be moved inside of Account()? It would remove duplication and ensure the a new caller of Account doesnt forget to call DecodeAddress first
This updates AccountID to check the provided address is valid for the active network before generating an id.
This decouples components initially bundled with the pool hub in order to better test them and ultimately improve test coverage for the pool.