Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing bracket to nginx config #443

Merged
merged 1 commit into from Jul 22, 2019
Merged

Add missing bracket to nginx config #443

merged 1 commit into from Jul 22, 2019

Conversation

jholdstock
Copy link
Member

No description provided.

@jholdstock jholdstock mentioned this pull request Jul 20, 2019
Merged
@JoeGruffins
Copy link
Member

JoeGruffins commented Jul 20, 2019 •
edited

@jholdstock Have you tried using on mobile with this? I don't think you can press the menu anymore. Also, this makes the changes involving assets useless on #429 Should assets route be removed from the handler completely after this?

@jholdstock
Copy link
Member Author

#429 is not useless - those middleware changes are still relevant when working in dev and allowing the dcrstakepool to serve the static assets. Nginx is for production.

I have not tested this with a mobile client and I am not easily able to right now. Can you investigate the issue further? Consider that a difference between mobile and desktop experience could be caused by the difficulty of clearing the cache on a mobile browser vs desktop.

@JoeGruffins
Copy link
Member

Ok.
It's working fine now. I think the problem was with my phone. Wouldn't be the first time. Sorry for the false alarm.

@dajohi dajohi merged commit 906db36 into decred:master Jul 22, 2019
@jholdstock jholdstock deleted the nginx2 branch August 30, 2019 13:45
girino added a commit to girino/dcrstakepool that referenced this pull request Sep 7, 2019
@girino
Merge commit '9a856a6308d0fa746bf0b455728ea299fb70024f'
14c3cbd 
* commit '9a856a6308d0fa746bf0b455728ea299fb70024f':
  stats.html: add Block Height to stats page (decred#440)
  Add missing bracket to nginx config (decred#443)
  Re-add support email address (decred#442)
jyap808 pushed a commit to ubiq/dcrstakepool that referenced this pull request Dec 12, 2019
@jholdstock @jyap808
Add missing bracket to nginx config (decred#443)
fdd04af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dajohi dajohi dajohi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jholdstock @JoeGruffins @dajohi