controllers/main.go: tickets rpc error page #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jholdstock
requested changes
Aug 16, 2019
JoeGruffins
force-pushed
the
ticketserror
branch
from
d724fa5
to
35b21d3
Compare
dajohi
approved these changes
Aug 19, 2019
UferePease
pushed a commit
to UferePease/dcrstakepool
that referenced
this pull request
Aug 20, 2019
itswisdomagain
pushed a commit
to itswisdomagain/dcrstakepool
that referenced
this pull request
Aug 20, 2019
girino
added a commit
to girino/dcrstakepool
that referenced
this pull request
Sep 7, 2019
* commit '56f730caaeabfec224aef219f0c32680a645b543': controllers/main.go: tickets rpc error page (decred#483) stakepooldclient: continue loop on error (decred#482) new architecture diagram (decred#485) controller/main.go: remove enableStakepoold field (decred#490) fix styling of error page (decred#488) fix styling of error page (decred#488) Status page improvements (decred#484) stakepooldclient: more informative errors (decred#481)
jyap808
pushed a commit
to ubiq/dcrstakepool
that referenced
this pull request
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all of the stakepoold servers are down, the comment on the error suggests that the user will see a message about trying again, but as it was written, all they see is
internal server error. This redirects to the default error page which does have a message saying to try again.