Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider tx fees when choosing a mix amount and count #1992

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

jrick
Copy link
Member

@jrick jrick commented Feb 17, 2021

Ignoring this can lead to unmixable outputs, as they will always be
rejected when submitted as a single input to the CoinShuffle++ server.

Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, but reads proper.

Copy link
Member

@alexlyp alexlyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Ignoring this when excluding a dust change output can lead to
unmixable outputs, as inputs will always be rejected when submitted as
a single input to the CoinShuffle++ server for that particular amount
and count.
@jrick jrick merged commit 487faa7 into decred:master Feb 18, 2021
@jrick jrick deleted the mixfees branch February 18, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants