Add new stake-related RPCs to the gRPC interface #293
Conversation
|
So this is happening. Will all legacy RPC commands get translated? |
|
@chappjc It's for the GUI, but in the future most new RPC calls will probably go through the gRPC. I doubt that all old commands will be translated, just the most important ones. |
| @@ -277,14 +279,42 @@ func (s *walletServer) ImportPrivateKey(ctx context.Context, req *pb.ImportPriva | |||
| "Only the imported account accepts private key imports") | |||
| } | |||
|
|
|||
| _, err = s.wallet.ImportPrivateKey(wif, nil, req.Rescan, 0) | |||
| _, err = s.wallet.ImportPrivateKey(wif, nil, req.Rescan, req.ScanFrom) | |||
There was a problem hiding this comment.
Before this, I would check for non-zero scan_from and error when rescan is false.
|
seems to run fine with ticketbuyer, tACK for legacy usage |
|
Mentioned in chat but saying it here too: needs doco added to |
| #### `ImportPrivateKey` | ||
|
|
||
| The `ImportScript` method imports a script into the transaction store and address | ||
| manager of the wallet.. A rescan may optionally be started to search for |
|
See https://godoc.org/google.golang.org/grpc/codes for the meanings of all of the gRPC status codes. |
|
|
||
| ___ | ||
|
|
||
| #### `ImportPrivateKey` |
|
I did some testing for normal wallet stuff (send, recieve, getstakeinfo, purchaseticket, etc) and all are fine. So while I have no comment on the grpc stuff (all you @jrick ) this doesn't break anything. |
| uint32 live = 5; | ||
| uint32 voted = 6; | ||
| uint32 missed = 7; | ||
| uint32 revoked = 8; |
There was a problem hiding this comment.
Should there be a placeholder for expired tickets?
https://forum.decred.org/threads/one-of-my-oldest-tickets-rip.3873/#post-21184
There was a problem hiding this comment.
Additional fields can be added in a backward-compatible way.
However i do think we should get it right the first time where possible. @cjepson can you add this field?
There was a problem hiding this comment.
I can add it, it's entirely possible in the future that it might exist. For now the server can simply set it to 0 and it can be ignored at the UI level.
cjepson
force-pushed
the
cj_080716grpcpurchaseticket
branch
from
fd0ad0b
to
46ecc53
Compare
| optionally be started to search for transactions involving the script, either | ||
| as an output or in a P2SH input. | ||
|
|
||
| **Request:** `ImportScriptRequest` |
There was a problem hiding this comment.
This message doco is missing the scan_from field.
There was a problem hiding this comment.
Also just noticed that this is missing the account. We should add it to the message and error whenever a script is imported into anything other than the imported account. Later on we will enable both script and private key imports for other accounts as well.
There was a problem hiding this comment.
I'll add scan_from, but I don't think we should have accounts for scripts as scripts can span no accounts (OP_TRUE) or many accounts (2-of-2 P2SH involving 2 accounts from the same wallet). That's why wallet also puts them in txstore unencrypted now, and in the future I would consider stripping them from the address manager completely because they're fundamentally different from an account or private key.
cjepson
force-pushed
the
cj_080716grpcpurchaseticket
branch
3 times, most recently
from
0dd7191
to
d37bab1
Compare
|
The |
cjepson
force-pushed
the
cj_080716grpcpurchaseticket
branch
2 times, most recently
from
e488487
to
aa4624e
Compare
| current stake difficulty is above this amount, the wallet will return an error. | ||
|
|
||
| - `uint32 required_confirmations`: The number of required confirmations for | ||
| funds used to purchase a ticket. If left unset, it will use unconfirmed and |
|
tACK with provided grpc example |
The following new stake related RPC calls have been added to the gRPC: 1. StakeInfo 2. TicketPrice 3. ImportScript 4. PurchaseTickets ImportPrivateKey has been updated to take the new ScanFrom variable from Decred. The GetStakeInfo handling method for the legacy RPC has been modified to call a more general API from wallet. The CreatePurchaseTicket API in wallet has been modified to take the fees to use for both the split transaction and ticket as arguments. The SemVer minor version for the gRPC server has been bumped to 2.2.0. The function to retrieve the stake difficulty from wallet has been changed to simply use the fetch function from the daemon, and the registration for stake difficulty notifications has been removed.
cjepson
force-pushed
the
cj_080716grpcpurchaseticket
branch
from
aa4624e
to
6087ab2
Compare
* Adds Privacy Page layout * Update Privacy Page - add wallet menu privacy item - create subpage layout for settings page - add resuable headers for subpage layouts - implement dangerZoneLayout collapsible - create privacyInfo modal - add modifiable title for modal
The following new stake related RPC calls have been added to the
gRPC:
ImportPrivateKey has been updated to take the new ScanFrom variable
from Decred.
The GetStakeInfo handling method for the legacy RPC has been modified
to call a more general API from wallet.
The CreatePurchaseTicket API in wallet has been modified to take the
fees to use for both the split transaction and ticket as arguments.
The SemVer minor version for the gRPC server has been bumped to 2.2.0.
The function to retrieve the stake difficulty from wallet has been
changed to simply use the fetch function from the daemon, and the
registration for stake difficulty notifications has been removed.