Fix panic when getting StakeDifficulty if dcrd disconnected #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK |
|
ok |
1 similar comment
|
ok |
StakeDifficulty and StakeInfo could potentially cause a panic if they did not have a safe pointer for the chainClient. requireChainClient is used to ensure that a nil pointer dereference never occurs.
cjepson
force-pushed
the
cj_270716walletpanic
branch
from
da1683c
to
f54ad6c
Compare
|
ok on the updates as well |
|
ok again |
beansgum
pushed a commit
to beansgum/dcrwallet
that referenced
this pull request
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling wallet.StakeDifficulty or wallet.StakeInfo would cause a panic if the daemon was not connected to the wallet. Now the chain client is loaded by the disconnection-safe w.requireChainClient.