getbalance: additional balance fixes #565
Conversation
dajohi
commented
Feb 15, 2017
•
dajohi
commented
- Include immature coinbase credits
- SSTXs are not coinbase rewards
- Also include unconfirmed in the total.
- Correctly add normal transactions to Spendable when minConf==0
- Handle unmined stake transactions properly.
wtxmgr/tx.go
Outdated
| // Make sure this output was not spent by an unmined transaction. | ||
| // If it was, skip this credit. | ||
| if existsRawUnminedInput(ns, k) != nil { | ||
| log.Warnf("existsRawUnminedInput") |
|
This is a whole lot of code with no explanation of what is being fixed, why, and how. |
|
Updated. The diff is removing if minConf == 0 { } .. but gofmt makes it look bigger :) |
|
minconf shouldn't be ignored completely, we still need to inspect whether minconf==0 before incrementing the spendable balance. |
wtxmgr/tx.go
Outdated
| default: | ||
| log.Warnf("Unhandled unconfirmed opcode %v: %v", opcode, v) | ||
| } else { | ||
| ab.ImmatureCoinbaseRewards += utxoAmt |
wtxmgr/tx.go
Outdated
| case OP_NONSTAKE: | ||
| fallthrough | ||
| case txscript.OP_SSTX: | ||
| if minConf == 0 { | ||
| ab.Spendable += utxoAmt |
There was a problem hiding this comment.
don't think spendable is correct here, this is in the stake tree and nothing in there is ever "spendable"
wtxmgr/tx.go
Outdated
| case txscript.OP_SSRTX: | ||
| fallthrough | ||
| case txscript.OP_SSTXCHANGE: | ||
| ab.ImmatureCoinbaseRewards += utxoAmt |
|
review. |
|
Needs rebase -- the new file to put these changes in is wallet/udb/txmined.go And since this also touches unmined transactions, perhaps it could be moved to a better named file. But that can be done in another pr. |
|
I want this in but it needs a better commit message before it will be accepted. what bugs were fixed? |
- Include immature coinbase credits - SSTXs are not coinbase rewards - Also include unconfirmed in the total. - Correctly add normal transactions to Spendable when minConf==0 - Handle unmined stake transactions properly.
