Prevent panic in JSON-RPC server. #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes panics caused by dereferencing a nil wallet to determine if an RPC that requires the --unsafemainnet flag when mainnet is the active network. The fix is to pass in the active network parameters to the RPC server and use those rather than trying to access them through the nil wallet.
jrick
force-pushed
the
unsafemainnetpanic
branch
from
6261ddf
to
7a80d9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes panics caused by dereferencing a nil wallet to determine if
an RPC that requires the --unsafemainnet flag when mainnet is the
active network. The fix is to pass in the active network parameters
to the RPC server and use those rather than trying to access them
through the nil wallet.
Fixes #650.