Get/SetTicketFee RPC and fix fee calculation in purchaseTicket #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // sstxSubsidyCommitmentEstimate = | ||
| // version + amount + OP_RETURN OP_DATA_30 | ||
| sstxSubsidyCommitmentEstimate = 2 + 8 + 30 |
There was a problem hiding this comment.
Need to count the 2 bytes for OP_RETURN OP_DATA_30 here.
|
Needs a squash and a rebase but then OK by me. |
|
New RPCs for the legacy server need help added to the rpchelp package. |
alexlyp
force-pushed
the
ayp_setticketfee
branch
2 times, most recently
from
cf63392
to
6544d60
Compare
|
Looks good now. Just rebase and it can go in. OK |
Fix estimateSSTxSize calcultion First use EstMaxTicketFeeAmount to ensure you get enough utxos. Then when actually calculating fees for tickets, use new consts: sstxTicketCommitmentEstimate sstxSubsidyCommitmentEstimate sstxChangeOutputEstimate
alexlyp
force-pushed
the
ayp_setticketfee
branch
from
6544d60
to
4f51acb
Compare
beansgum
pushed a commit
to beansgum/dcrwallet
that referenced
this pull request
Jun 10, 2021
* wallet: change struct RecentTransaction to Transaction - Transactions.Txs slice of dcrlibwallet.Transaction to slice of Transaction * ui: create transaction details page - Add transaction widgets for layouts and inputs/outputs - Handler transaction inputs widgets - Implement click able to transaction on "overview page" - window add `walletTransaction *wallet.Transaction` contains transaction info * ui: update transaction details - Display transaction confirmations number - Click on "View on dcrdata" button will open txn on browser - Add click event to transaction item on transaction_page.go * wallet: Update transaction listener - Add "GetTransaction" to get transaction details - Add const "BlockAttached" - Update "txlistener.go", OnBlockAttached and OnTransactionConfirmed * ui: Update transaction details page - Add NavigationArrowBack icon widget to page common *ui: Update Transaction details - Change transaction.go -> transaction_details_page.go - Layout the page with Navigation Tabs - Add txsToTxsDetails at transactions.go - Remove toTransactionDetails at widgets.go * ui: Implement click on txs rows Co-authored-by: Song <song@zz.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add simple functionality to get/set ticketFeeIncrement. This will enable users to set the per kb fees for stake ticket purchasing.
Also add fixes to purchaseTicket fee calculation. Before amountNeeded for the eligible utxos wasn't taking into account needed fees. estimateSSTxSize is now fixed to use current sizes of the 3 output types of sstx.