Skip to content

Commit

Permalink
Fix bugs found during patch release testing (#457)
Browse files Browse the repository at this point in the history
  • Loading branch information
alexlyp committed Jun 21, 2017
1 parent 5bae48d commit e8788e3
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 7 deletions.
2 changes: 1 addition & 1 deletion app/actions/ClientActions.js
Expand Up @@ -136,7 +136,7 @@ function getBalanceSuccess(account, getBalanceResponse) {
var updatedBalances = balances;
var found = false;
for (var i = 0; i < balances.length; i++) {
if (balances[i].accountNumber == accountNumber) {
if (balances[i].accountNumber == account.getAccountNumber()) {
updatedBalances[i] = updatedBalance;
found = true;
}
Expand Down
1 change: 1 addition & 0 deletions app/actions/NotificationActions.js
Expand Up @@ -113,6 +113,7 @@ function transactionNtfnsData(response) {
dispatch({currentHeight: currentHeight, timeBackString: timeBackString(daysBack), type: TRANSACTIONNTFNS_SYNCING });
}
} else if (response.getUnminedTransactionsList().length > 0) {
setTimeout( () => {dispatch(getAccountsAttempt());}, 1000);
for (var z = 0; z < response.getUnminedTransactionsList().length; z++) {
var found = false;
for (var y = 0; y < unmined.length; y++) {
Expand Down
2 changes: 1 addition & 1 deletion app/components/AccountRow.js
Expand Up @@ -241,7 +241,7 @@ class AccountRow extends Component {
const { account } = this.props;
return (
<div style={this.state.showAccountDetails ? this.state.showRenameAccount ? styles.accountRowRename : styles.accountRowLong : styles.accountRowShort}>
<div style={this.state.showAccountDetails ? styles.accountRowDetailsTop : styles.accountRow} key={account.accountNumber} onClick={this.state.showAccountDetails ? () => this.setState({showAccountDetails: false}) : () => this.setState({showAccountDetails: true})}>
<div style={this.state.showAccountDetails ? styles.accountRowDetailsTop : styles.accountRow} key={'top'+account.accountNumber} onClick={this.state.showAccountDetails ? () => this.setState({showAccountDetails: false}) : () => this.setState({showAccountDetails: true})}>
<div style={styles.accountRowTopTop}>
<div style={styles.accountRowWalletIcon}/>
<div style={styles.accountRowTopAccountName}>{account.accountName}</div>
Expand Down
2 changes: 1 addition & 1 deletion app/components/views/Accounts.js
Expand Up @@ -104,7 +104,7 @@ class Accounts extends Component{
balances !== null ?
<div style={AccountStyles.contentNest}>
{balances.map((account) => {
return (<AccountRow key={account.accountName} account={account} renameAccount={(name, number) => this.props.renameAccountAttempt(name, number)}/>);
return (<AccountRow key={'accountRow' + account.accountName} account={account} renameAccount={(name, number) => this.props.renameAccountAttempt(name, number)}/>);
})}
</div>:
<div></div>
Expand Down
13 changes: 9 additions & 4 deletions app/components/views/Send.js
Expand Up @@ -160,11 +160,16 @@ class Send extends Component{
units = 1;
}
var updateOutputs = this.state.outputs;
if (amount < 0) {
updateOutputs[outputKey].amountError = '*Please enter a valid amount (> 0)';
if (isNaN(parseInt(amount))) {
updateOutputs[outputKey].amountError = '*Please enter a valid amount';
updateOutputs[outputKey].amount = 0;
} else {
updateOutputs[outputKey].amount = amount * units;
updateOutputs[outputKey].amountError = null;
if (parseInt(amount) <= 0) {
updateOutputs[outputKey].amountError = '*Please enter a valid amount (> 0)';
} else {
updateOutputs[outputKey].amount = parseInt(amount) * units;
updateOutputs[outputKey].amountError = null;
}
}
var totalOutputAmount = 0;
for (var i = 0; i < updateOutputs.length; i++){
Expand Down

0 comments on commit e8788e3

Please sign in to comment.