Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate styles #298

Closed
jcvernaleo opened this issue Mar 24, 2017 · 2 comments
Closed

Consolidate styles #298

jcvernaleo opened this issue Mar 24, 2017 · 2 comments
Milestone

Comments

@jcvernaleo
Copy link
Member

Currently each page has a section with things like:

const styles = {
  body: {
    position: 'fixed',
    left: '0px',

to keep all the inline css.

We can probably organize and reuse these pieces a bit better. Not sure exactly what yet, but worth keeping in mind.

@alexlyp
Copy link
Member

alexlyp commented Apr 5, 2017

So now we have 1 consolidated file (ViewStyles.js) as our main spot for various styles for views. For now I'm going to keep reused component styles in their own file (ToggleButton, KeyBlueButton, etc)

Next step is to see where we have overlap so we can use one main reused const for body, view etc

@alexlyp
Copy link
Member

alexlyp commented Aug 3, 2017

Closing in lieu of @go1dfish's #528

@alexlyp alexlyp closed this as completed Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants