Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host & Port not hardcoded anymore #1988

Merged
merged 1 commit into from Feb 11, 2019

Conversation

laszlolm
Copy link
Contributor

Solving #1983

Copy link
Contributor

@szpasztor szpasztor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for #1975 as some of the code that needs to be changed isn't merged yet.

Copy link
Member

@vctt94 vctt94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this startRpcRequestFunc method needs a refactor, because it is an old method we used to use, but a lot have changed on how decrediton and daemon are started.

Right now credentials are coming from the launchDCRD method, so this change are not really having effect at the code.

If you do console.log(cfg.get("rpc_host")), for example, it will probably be undefined, because they are not at the config file. Unless you manually added it.

@alexlyp
Copy link
Member

alexlyp commented Feb 11, 2019

Sort of bouncing off of @vctt94's comment, but yah I believe these changes are essentially a noop. But it does make everything more consistent so I'm willing to change it.

Overall as @vctt94 mentioned the function should probably be refactored at some point.

@alexlyp alexlyp merged commit fcc9c40 into decred:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants