Add no more tickets design #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a difference between "No more tickets" (implying some tickets were found and after retrieving those there aren't any more tickets to fetch) vs "no tickets found" (meaning zero tickets were found) so we might need some clarification from @linnutee whether they are intended to be used interchangeably. |
|
I agree with you it can be a bit confusing. Maybe we can have the same indicator but different messages, but I will wait linnutee speaks his thoughts on this one. |
|
@linnutee can you chime in on this please? |
|
Yup I'll create a second state design for the "No more Tickets" as well. |
matheusd
approved these changes
Aug 8, 2019
|
needs a rebace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1252 and closes #2165