Import script watch only #2423
Merged
Import script watch only #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
matheusd
reviewed
Feb 20, 2020
app/wallet/control.js
Outdated
Comment on lines
58
to
61
| // watch only wallets are not redeemable of their scripts, therefore we | ||
| // don't require them to be redeemable. | ||
| const isRequireRedeem = isWatchingOnly ? false : true; | ||
| request.setRequireRedeemable(isRequireRedeem); |
There was a problem hiding this comment.
This isn't true. The "redeemable" part checks whether one of the addresses of the multisig belogs to the wallet, irrespective of whether the wallet has the private keys for that address or not.
So I think this should remain true even for watching only wallets since it ensures the corresponding (cold) wallet will have the keys for at least one of the pubkeys in the script.
There was a problem hiding this comment.
Yeah, you are right. Fixed
vctt94
force-pushed
the
import-script-watch-only
branch
from
283b5ff
to
0cb06a8
Compare
matheusd
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to watching only wallets import scripts.
It is a work towards #1491