-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetStarted & Settings Pages: functional components, css module & custom hooks #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amass01
changed the title
Settings Page: functional components, css module & custom hooks
[WIP] Settings Page: functional components, css module & custom hooks
Jun 16, 2020
amass01
changed the title
[WIP] Settings Page: functional components, css module & custom hooks
[WIP] GetStarted & Settings Pages: functional components, css module & custom hooks
Jun 19, 2020
amass01
changed the title
[WIP] GetStarted & Settings Pages: functional components, css module & custom hooks
GetStarted & Settings Pages: functional components, css module & custom hooks
Jun 24, 2020
vctt94
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! It looks really good, can't wait to see the getStarted code with functional components! It will look much better.
alexlyp
approved these changes
Jun 29, 2020
This was referenced Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff was suppose to be a preparation step for #2531, as the settings page is part of the get started pages.
but giving the fact that they are very related and interconnected I couldn't finish SettingsPage dir refactoring without partly refactoring GetStartedPage dir - the css module part was done in this PR(see below detailed list of included changes).
This commit also closes #2503 as I fixed the alignment issues will working on
tutorial.module.css
.Changes included:
useSettings
&useService
as they are used in multiple places and aren't SettingsPage view specific - connectors are still there as they are still used in other parts of the app.Settings.less
&GetStarted.less
& other*.less
files which are related to them were replaced with css module and split into multiple css modules in some cases, here is the full list of migrated*.less
files:Settings.less
=>views/SettingsPage/Settings.module.css
,components/indicators/indicators.module.css
GetStarted.less
=>views/GetStartedPage/GetStarted.module.css
CreateWalletForm.less
=>views/GetStartedPage/CreateWalletPage/CreateWallet.module.css
,/shared/CreatePassPhrase/CreatePassPhrase.module.css
LanguageSelect.less
=>/views/GetStartedPage/LanguageSelectPage/LanguageSelectPage.module.css
,inputs/LanguageSelectInput/LanguageSelectInput.module.css
Logs.less
=>/views/HelpPage/LogsTab/LogsTab.module.css
Tutorial.less
=>/views/GetStartedPage/TutorialPage/Tutorial.module.css
- partly done, some parts are used on in other pages.