Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetStarted & Settings Pages: functional components, css module & custom hooks #2537

Merged
merged 26 commits into from
Jun 29, 2020

Conversation

amass01
Copy link
Member

@amass01 amass01 commented Jun 16, 2020

This diff was suppose to be a preparation step for #2531, as the settings page is part of the get started pages.
but giving the fact that they are very related and interconnected I couldn't finish SettingsPage dir refactoring without partly refactoring GetStartedPage dir - the css module part was done in this PR(see below detailed list of included changes).
This commit also closes #2503 as I fixed the alignment issues will working on tutorial.module.css.

Changes included:

  • SettingsPage class components refactored to be functional.
  • Added global hooks useSettings & useService as they are used in multiple places and aren't SettingsPage view specific - connectors are still there as they are still used in other parts of the app.
  • As mentioned above Settings.less & GetStarted.less & other *.less files which are related to them were replaced with css module and split into multiple css modules in some cases, here is the full list of migrated *.less files:
    • Settings.less => views/SettingsPage/Settings.module.css, components/indicators/indicators.module.css
    • GetStarted.less => views/GetStartedPage/GetStarted.module.css
    • CreateWalletForm.less => views/GetStartedPage/CreateWalletPage/CreateWallet.module.css, /shared/CreatePassPhrase/CreatePassPhrase.module.css
    • LanguageSelect.less => /views/GetStartedPage/LanguageSelectPage/LanguageSelectPage.module.css, inputs/LanguageSelectInput/LanguageSelectInput.module.css
    • Logs.less => /views/HelpPage/LogsTab/LogsTab.module.css
    • Tutorial.less => /views/GetStartedPage/TutorialPage/Tutorial.module.css - partly done, some parts are used on in other pages.
  • Fixed tutorial alignment issues reported in Get started pages text alignment  #2503.

@amass01 amass01 changed the title Settings Page: functional components, css module & custom hooks [WIP] Settings Page: functional components, css module & custom hooks Jun 16, 2020
@amass01 amass01 marked this pull request as draft June 16, 2020 20:41
@amass01 amass01 changed the title [WIP] Settings Page: functional components, css module & custom hooks [WIP] GetStarted & Settings Pages: functional components, css module & custom hooks Jun 19, 2020
@amass01 amass01 marked this pull request as ready for review June 24, 2020 23:20
@amass01 amass01 changed the title [WIP] GetStarted & Settings Pages: functional components, css module & custom hooks GetStarted & Settings Pages: functional components, css module & custom hooks Jun 24, 2020
Copy link
Member

@vctt94 vctt94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! It looks really good, can't wait to see the getStarted code with functional components! It will look much better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get started pages text alignment
3 participants