Add set account passphrase #2664

vctt94 · 2020-09-09T20:15:29Z

~~contains db upgrade -- backup db before testing~~

~~This PR depends on #2665 and on decred/dcrwallet#1823~~

~~This PR depends on decred/dcrwallet#1979~~

~~depends on #3337~~

MAKE A DB BACKUP BEFORE TESTING, AS IT WILL SET ALL ACCOUNTS YOUR WALLET PASSPHRASE

This PR adds a new step into the setup wallet machine, which sets all account's passphrase as the wallet passhrase.

Right now what I changed to use lock/unlock account instead of wallet:

send tx;
purchase ticket and auto buyer (legacy and non legacy);
privacy - running the mixer.

The rest of the wallet operations still are with old functionalities

alexlyp · 2020-09-22T14:40:55Z

Can rebase this now that 2665 is in

alexlyp · 2020-09-22T15:39:31Z

Hrm looks like there's another rebase that's needed, sorry

alexlyp · 2021-02-19T18:14:33Z

Now that 1.6.1 is pretty much done, a rebase is due on this one.

matheusd · 2021-02-22T20:48:23Z

app/actions/ControlActions.js

+  try {
+    const acctNumber = acct.encrypted ? acct.value : null;
+    const error = await dispatch(unlockWalletOrAcct(passphrase, acctNumber));
+    if (error) {
+      return dispatch({ error, type: SIGNTX_FAILED });
+    }
+    const signTransactionResponse = await wallet.signTransaction(
+      sel.walletService(getState()),
+      rawTx
+    );
+    dispatch({
+      signTransactionResponse: signTransactionResponse,
+      type: SIGNTX_SUCCESS
+    });
+    dispatch(
+      publishTransactionAttempt(signTransactionResponse.getTransaction())
+    );
+    await dispatch(lockWalletOrAcct(acctNumber));
+  } catch(error) {
+    dispatch({ error, type: SIGNTX_FAILED });
+  }


This whole thing can leave the account unlocked if signTransaction fails (since that could trigger an exception).

In general, the unlockWalletOrAcct(); doSomething(); lockWalletOrAcct() pattern is going to be tricky to get (and maintain) correct at every instance an account unlocking can happen.

I suggest writing generic unlock/lock action, that takes as argument an async function and then unconditionally performs the unlock. Something like:

export const performWithUnlockedAccount = async (passphrase, acct, fn) => (dispatch) => { // TODO: error handling, etc await dispatch(unlockWalletOrAcct(passphrase, acctNumber)); let fnError; let res; try { res = await fn(); } catch (error) { fnError = error } await dispatch(lockWalletOrAcct(acctNumber)); if (fnError) throw fnError; return res; }

matheusd · 2021-02-22T20:57:29Z

app/actions/ControlActions.js

+  const { ticketBuyerService } = getState().grpc;
+  dispatch({ ticketBuyerConfig, type: STARTTICKETBUYERV2_ATTEMPT });
+  const accountNum = account.encrypted ? account.value : null;
+  const error = await dispatch(unlockWalletOrAcct(passphrase, accountNum));


If I send a generic tx from the same account the ticket buyer is purchasing tickets from, will the lockWalletOrAcct() call at the end of transaction interfere with the ticketbuyer?

Now it is not possible to do other actions while mixer or auto buyer is running, anymore.

amass01

Code looks good overall, left some minors.

amass01 · 2021-04-08T19:55:05Z

...ents/views/GetStartedPage/SetupWallet/SettingAccountsPassphrase/SettingAccountsPassphrase.js

+import { PassphraseModalButton, InvisibleButton } from "buttons";
+import styles from "./SettingAccountsPassphrase.module.css";
+
+export default ({


pls use const SettingAccountsPasspharse.
Also, I feel that SetAccountsPasspharse might be a better name for this component.

amass01 · 2021-04-08T20:08:08Z

app/wallet/control.js

@@ -461,9 +443,11 @@ export const setVspdAgendaChoices = (
 export const unlockWallet = (walletService, passphrase) =>
  new Promise((resolve, reject) => {
    const unlockReq = new api.UnlockWalletRequest();
+    console.log(console.log(passphrase));


amass01 · 2021-04-08T20:08:16Z

app/wallet/control.js

    unlockReq.setPassphrase(new Uint8Array(Buffer.from(passphrase)));
    // Unlock wallet so we can call the request.
    walletService.unlockWallet(unlockReq, (error) => {
+      console.log(error);


amass01 · 2021-04-08T20:08:30Z

app/wallet/control.js

-          resolve(response);
-        });
-      });
+


unnecessary empty line

alexlyp · 2021-04-08T21:28:52Z

On the Account passphrase page during start up with Skip and X button are shown. These should all be hidden since we are going to force the upgrade.

alexlyp · 2021-04-08T21:29:35Z

I'll work on some copy to use on startup page.

matheusd · 2021-04-09T12:24:27Z

app/actions/ControlActions.js

+    dispatch(
+      publishTransactionAttempt(signTransactionResponse.getTransaction())
+    );
+    await dispatch(lockWalletOrAcct(acctNumber));


Is this still needed now that signing happens inside unlockAcctAndExecFn?

matheusd · 2021-04-09T12:24:51Z

app/actions/ControlActions.js

-        type: CREATE_UNSIGNEDTICKETS_SUCCESS
-      });
-    }
+    await dispatch(lockWalletOrAcct(accountNum));


Still needed?

matheusd · 2021-04-09T12:25:44Z

app/actions/ControlActions.js

+export const UNLOCKACCTORWALLET_FAILED = "UNLOCKACCTORWALLET_FAILED";
+export const UNLOCKACCTORWALLET_SUCCESS = "UNLOCKACCTORWALLET_SUCCESS";
+
+// unlockAcctAndExecFn unlocks the account and perform some acction. Locks the


perform => performs
acction => action

matheusd · 2021-04-09T12:30:56Z

app/actions/ControlActions.js

+  if (fnError !== null) {
+    throw fnError;
+  }


This will leave the account unlocked if fnError is filled in the block above. This needs to happen after the wallet is locked (if leaveUnlock is false).

true, good catch.

…unts

vctt94 changed the title ~~Start adding set account passphrase~~ [wip]Start adding set account passphrase Sep 9, 2020

vctt94 mentioned this pull request Sep 10, 2020

[clean up] Refactor passphrase modal #2665

Merged

vctt94 force-pushed the add-per-acct-encryption branch 2 times, most recently from 88f8508 to 8cbf22e Compare September 11, 2020 15:20

vctt94 changed the title ~~[wip]Start adding set account passphrase~~ Add set account passphrase Sep 12, 2020

vctt94 force-pushed the add-per-acct-encryption branch from b108de9 to 189e0e2 Compare September 12, 2020 12:58

vctt94 force-pushed the add-per-acct-encryption branch from eeb45ce to 39bf5db Compare September 22, 2020 14:57

vctt94 force-pushed the add-per-acct-encryption branch 2 times, most recently from ed69274 to 2250d5d Compare September 28, 2020 18:10

vctt94 force-pushed the add-per-acct-encryption branch from 2752464 to 36aaa6d Compare January 28, 2021 14:41

vctt94 changed the title ~~Add set account passphrase~~ [wip] Add set account passphrase Jan 28, 2021

vctt94 force-pushed the add-per-acct-encryption branch from 36aaa6d to 15b6df5 Compare February 2, 2021 14:45

vctt94 changed the title ~~[wip] Add set account passphrase~~ Add set account passphrase Feb 3, 2021

matheusd reviewed Feb 26, 2021

View reviewed changes

vctt94 force-pushed the add-per-acct-encryption branch from 0dbe02b to cf669c0 Compare March 23, 2021 14:50

vctt94 changed the title ~~Add set account passphrase~~ [wip] Add set account passphrase Mar 23, 2021

vctt94 force-pushed the add-per-acct-encryption branch 7 times, most recently from 82bed7c to 590c20d Compare April 8, 2021 18:25

amass01 reviewed Apr 8, 2021

View reviewed changes

matheusd reviewed Apr 9, 2021

View reviewed changes

vctt94 added 22 commits April 23, 2021 13:52

fix tests

22d6cd4

int dup

ef2d524

review fixes

11cd74e

Remove skip and go back button

b10e1dc

lint

2c99909

fixes after rebase

daae9f9

Change process managed and unmanged to unlock account

38d6a83

clean up and fixes from rebase

4720b52

prettify

d91313a

add missing dispatches and fix not dealing with error on process acco…

aeaff07

…unts

lint

82aefc0

skip trezor and watching only wallets

18144f0

change sign message to new method

ff9aa6d

clean up

ed05431

prettify

af100ad

fix vote proposal

04cee39

prettify

4109d79

Add running indicator into LN

3dc4277

update copy

50ac43f

do not allow lock of dex account

66608c3

lint and prettify

c6a4028

handle case dexAccount not exists

95886d6

vctt94 force-pushed the add-per-acct-encryption branch from 491e7c7 to 95886d6 Compare April 23, 2021 16:56

matheusd mentioned this pull request Apr 23, 2021

Add decrediton/migrations page decred/dcrdocs#1163

Merged

vctt94 added 2 commits April 23, 2021 14:11

prettify

5ee3bea

Add external link

5d7e593

vctt94 force-pushed the add-per-acct-encryption branch from a452bc6 to 5d7e593 Compare April 23, 2021 19:32

matheusd approved these changes Apr 23, 2021

View reviewed changes

alexlyp approved these changes Apr 23, 2021

View reviewed changes

alexlyp merged commit 2ecaffe into decred:master Apr 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add set account passphrase #2664

Add set account passphrase #2664

vctt94 commented Sep 9, 2020 •

edited

alexlyp commented Sep 22, 2020

alexlyp commented Sep 22, 2020

alexlyp commented Feb 19, 2021

matheusd Feb 22, 2021

matheusd Feb 22, 2021

vctt94 Apr 8, 2021

amass01 left a comment

amass01 Apr 8, 2021

amass01 Apr 8, 2021

amass01 Apr 8, 2021

amass01 Apr 8, 2021

alexlyp commented Apr 8, 2021

alexlyp commented Apr 8, 2021

matheusd Apr 9, 2021

matheusd Apr 9, 2021

matheusd Apr 9, 2021

matheusd Apr 9, 2021

vctt94 Apr 9, 2021

Add set account passphrase #2664

Add set account passphrase #2664

Conversation

vctt94 commented Sep 9, 2020 • edited

alexlyp commented Sep 22, 2020

alexlyp commented Sep 22, 2020

alexlyp commented Feb 19, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amass01 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexlyp commented Apr 8, 2021

alexlyp commented Apr 8, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vctt94 commented Sep 9, 2020 •

edited