-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error handling on existing seed view #2683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR.
I left a couple of comments, but I like the direction this is going.
app/components/views/GetStartedPage/CreateWalletPage/ExistingSeed/ExistingSeed.jsx
Show resolved
Hide resolved
app/components/views/GetStartedPage/CreateWalletPage/ExistingSeed/ExistingSeed.jsx
Show resolved
Hide resolved
app/components/views/GetStartedPage/CreateWalletPage/ExistingSeed/ExistingSeed.jsx
Outdated
Show resolved
Hide resolved
Thank you for your review. I fixed your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing my comments.
I have a couple more comments.
I noticed it is possible when entering a word in its wrong place, the wallet throws an error, but it does not show right after it. It only shows after you entering the next word, example:
Here the absurd word already errored, as you can see at decrediton logs:
But it only shows as wrong if I add the third word:
And if I delete the word from its position, the field border gets missed:
I also think it would be good keeping the error message instead of just making the word red, as it can be a bit confusing. Making it red and showing an error message like "word on position n is wrong" would make it clearer. What do you think?
d194ba0
to
13bf511
Compare
Thank you for your review. I fixed the mentioned issues and cleaned up the component a bit. Also, I added the suggested error message. It is much more straightforward now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good job on this PR!
This diff improves the error handling on the existing seed view by changing the input's border color to red if the seed word is not at valid position.
![ksnip_20201001-200949](https://user-images.githubusercontent.com/52497040/94849056-21111200-0425-11eb-9126-3a948898fa4f.png)