Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling on existing seed view #2683

Merged
merged 3 commits into from
Oct 12, 2020

Conversation

bgptr
Copy link
Collaborator

@bgptr bgptr commented Oct 1, 2020

This diff improves the error handling on the existing seed view by changing the input's border color to red if the seed word is not at valid position.
ksnip_20201001-200949

Copy link
Member

@vctt94 vctt94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.

I left a couple of comments, but I like the direction this is going.

@bgptr
Copy link
Collaborator Author

bgptr commented Oct 2, 2020

Thank you for your review. I fixed your comments.

Copy link
Member

@vctt94 vctt94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing my comments.

I have a couple more comments.

I noticed it is possible when entering a word in its wrong place, the wallet throws an error, but it does not show right after it. It only shows after you entering the next word, example:

Here the absurd word already errored, as you can see at decrediton logs:

image

But it only shows as wrong if I add the third word:

image

And if I delete the word from its position, the field border gets missed:

image

I also think it would be good keeping the error message instead of just making the word red, as it can be a bit confusing. Making it red and showing an error message like "word on position n is wrong" would make it clearer. What do you think?

@bgptr
Copy link
Collaborator Author

bgptr commented Oct 8, 2020

Thank you for your review. I fixed the mentioned issues and cleaned up the component a bit. Also, I added the suggested error message. It is much more straightforward now.

Copy link
Member

@vctt94 vctt94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job on this PR!

@alexlyp alexlyp merged commit 3ec1afe into decred:master Oct 12, 2020
@bgptr bgptr deleted the improve-error-handling branch February 9, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants