Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carry over settings from past instances #276

Merged
merged 5 commits into from Mar 3, 2017

Conversation

alexlyp
Copy link
Member

@alexlyp alexlyp commented Mar 3, 2017

Fixes #204

dispatch({ tempSettings: settings, type: SETTINGS_CHANGED});
} else {
console.log('settings changed! same as currentSettings');
console.log('settings unchanged! same as currentSettings');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any log statements should either be removed or inside and if (debug) check.

}

console.log(rpcport);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another log line.

app/index.js Outdated

if (cfg.network == 'testnet') {
grpcport = cfg.wallet_port_testnet;
console.log(cfg.get('network'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more log.

@alexlyp alexlyp merged commit f5a3cdc into decred:master Mar 3, 2017
@alexlyp alexlyp deleted the ayp_set_settings branch March 3, 2017 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants