-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VSP] save last used VSP host #2789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR.
The vsp should be a wallet config and not a global config, as each wallet can have different vsps selected, as default.
Thank you for the review. |
can we have this as an optional clickable setting ? worried about centralization risks here. We want people to feel like they can choose any VSP they want. |
I've tried out the checkbox, I like the idea but it needs refining. I suggest
|
9fbdb99
to
370580c
Compare
@jholdstock I like your suggestions. I've implemented them. |
Looking better but it seems like the selected vsp and checkbox are resetting when I closed/reopen decrediton. Edit: Actually, I dont even need to restart decrediton. Just opening a new tab resets the values. |
@jholdstock You are right. Probably it's because I saved the VSP host only after successful ticket purchasing. I revamped (and also cleaned up) the code to save immediately after clicking on the checkbox. |
needs rebase |
cee2a28
to
3fa3a33
Compare
rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a good start and we can iterate from here. Thanks @bgptr
This update saves the last used VSP host to config after a successful ticket purchase on the new VSP page and sets the VSPSelects when the user arrives next time.
Closes #2763