Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update grpc for new version (4.5.0) #281

Merged
merged 1 commit into from Mar 8, 2017
Merged

Update grpc for new version (4.5.0) #281

merged 1 commit into from Mar 8, 2017

Conversation

alexlyp
Copy link
Member

@alexlyp alexlyp commented Mar 8, 2017 •
edited

Includes initial start/stop for ticketbuyer
Requires updated version of dcrwallet to be included in package

jcvernaleo
jcvernaleo suggested changes Mar 8, 2017
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you point out in the commit that this needs a newer version of dcrwallet. I know it says it is bumping grpc but that could be our stuff or the upstream package so probably better to be explicit here.

@alexlyp
Update grpc for new version (4.5.0)
5152324 
This will require the new version of dcrwallet to be included
in the packaged version.
jcvernaleo
jcvernaleo approved these changes Mar 8, 2017
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@alexlyp alexlyp merged commit dc9e4ac into decred:master Mar 8, 2017
@alexlyp alexlyp deleted the ayp_update_rpc branch March 8, 2017 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcvernaleo jcvernaleo jcvernaleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexlyp @jcvernaleo