multi: Allow trezor ticket purchasing on testnet. #2869

JoeGruffins · 2020-11-06T06:40:28Z

Fix updating firmware with model T by sending binary rather than hex.

In signTransactionAttemptTrezor give spending from stake scripts
inputs specific script types "SPENDSSRTX" and "SPENDSSGEN" rather than
"SPENDADDRESS" as trezor needs this information to process the scripts.

Add purchaseTicketsV3 which purchases tickets using a watching only
trezor wallet from a vsp with api v3. Errors if not on testnet.

Add separate payVSPFee function that will pay a tickets fee if not
already paid, and throws if already paid.

Correct purchase ticket button for watching only wallets. It no longer
asks for a password. Connect purchasing through trezor when isTrezor is
true.

Add vsp v3 endpoints "feeaddress" and "payfee" to allowed external
requests.

Change wallet/control.js to not require an unlocked wallet when signTx
is false.

JoeGruffins

Lots of TODO's but hopefully that's ok. This pr only means to get the ball rolling on testnet.

JoeGruffins · 2020-11-18T03:54:39Z

app/actions/TrezorActions.js

+    await signTransactionAttemptTrezor(splitTx, changeIndex)(dispatch, getState);
+    const refTxs = await walletTxToRefTx(walletService, decodedInp);
+
+    for (const ticket of res.getTicketsList()) {


Even when specifying number of tickets as more, this only returns one ticket. Am I doing it wrong?

app/actions/TrezorActions.js

JoeGruffins · 2020-11-18T03:57:37Z

app/actions/TrezorActions.js

+    // TODO: Fill this with deterministic crypto magic.
+    const privateKeySeed = Buffer.alloc(32);
+    privateKeySeed[31] = 1;
+    const net = conToTrezCoinParams(chainParams.trezorCoinName);
+    const ecp = ECPair.fromPrivateKeyBuffer(privateKeySeed, net);
+    const votingKey = ecp.toWIF();
+    const votingAddr = ecp.getAddress();


This will need to be changed but hopefully ok for now.

app/actions/TrezorActions.js

JoeGruffins · 2020-11-18T04:37:51Z

app/actions/TrezorActions.js

+// payVSPFee attempts to contact a vst about a ticket and pay the fee if
+// necessary. It will search transacitons for a suitable fee transaction before
+// attempting to pay if newTicket is false.
+async function payVSPFee(host, txHex, votingKey, accountNum, newTicket, dispatch, getState) {


This will need to be callable from somewhere else eventually. Will need to know the host though, and I'm not where to save that info. I suppose the user can choose per ticket where they think it came from if they still need to pay the fee for some reason. This will require ui changes which I am not comfortable doing in this pr...

JoeGruffins · 2020-11-18T04:39:24Z

app/actions/TrezorActions.js

+// findFeeTx searches unmined and recent transactions for a tx that pays to
+// FeeAddr of the amount feeAmt. It stops searching below a resonable depth for
+// a ticket.
+async function findFeeTx(feeAddr, feeAmt, dispatch, getState) {


This looks to work well, but if there's a better way please tell me.

app/main_dev/ipc.js

JoeGruffins · 2020-11-18T04:45:20Z

This pr should be used with trezor core firmware trezor/trezor-firmware#1249

app/actions/TrezorActions.js

JoeGruffins · 2020-11-19T01:25:28Z

Two more gotchas I forgot to mention:

~~The wallet must be in spv mode.~~ edit: Fixed by @matheusd
You must give the wallet some time to get ready after opening to attempt a purchase. Otherwise the grpc call hangs.

These are both problems that must be fixed at some point.

JoeGruffins · 2020-11-20T02:34:31Z

Another "insufficient funds" issue has been popping up. No idea of the cause right now, but it can be temporary solved by sending a normal transaction to yourself.

JoeGruffins · 2020-11-25T06:10:38Z

app/actions/TrezorActions.js

+    for (let i = 0; i < decodedInp.outputs.length; i++) {
+      changeIndexes.push(i);
+    };
+    await signTransactionAttemptTrezor(splitTx, changeIndexes)(dispatch, getState);


Cancelling this on trezor doesn't stop the purchase but it should.

JoeGruffins · 2020-11-25T06:11:11Z

app/actions/TrezorActions.js

+// payVSPFee attempts to contact a vst about a ticket and pay the fee if
+// necessary. It will search transacitons for a suitable fee transaction before
+// attempting to pay if newTicket is false.
+async function payVSPFee(host, txHex, votingKey, accountNum, newTicket, dispatch, getState) {


Should probably move these functions to helpers.

JoeGruffins · 2020-11-25T07:22:08Z

app/actions/TrezorActions.js

+  const {
+    grpc: { votingService  }
+  } = getState();
+  const voteChoicesRes = await wallet.getVoteChoices(votingService);


I assume this is fetching the default.

matheusd

~~Please just drop the binary files and I'll merge this.~~

Commented on the wrong PR, sorry.

JoeGruffins · 2021-03-26T05:08:39Z

Should I be worried about these test failures?

matheusd · 2021-03-26T11:56:40Z

Have you rebased to latest master yet? That might fix it.

amass01 · 2021-03-26T12:15:47Z

Something is off with the CI, looking into it...

JoeGruffins · 2021-03-26T23:24:20Z

Have you rebased to latest master yet? That might fix it.

Yes. I also tried the tests locally, on master, and had some fail. Not sure if there is something to do besides yarn run though.

Will do another rebase though, as there are some conflicts now.

amass01 · 2021-03-26T23:50:43Z

Will do another rebase though, as there are some conflicts now.

Latest master might resolve the CI troubles.

JoeGruffins · 2021-03-27T02:04:06Z

This looks like an expected test failure, will fix.

JoeGruffins · 2021-06-08T12:46:41Z

@matheusd please advise if 96c8c3e is the right way to handle this. Also, not sure about the build failure. It's working locally.

edit: nevermind. I removed the dependency.

matheusd

Purchasing worked on the latest stable version of the model T emulator (2.4.0). Woop! 🎉

app/helpers/msgTx.js

app/actions/TrezorActions.js

JoeGruffins · 2021-07-07T09:45:44Z

Getting an error like

Access to fetch at 'https://testnet-vsp.jholdstock.uk/api/v3/feeaddress' from origin 'http://localhost:3000' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: It does not have HTTP ok status.

suddenly. looking into it...

f448243 did something

It looks like tweaking some nginx fields on the server has fixed it.

JoeGruffins · 2021-10-28T06:56:45Z

The values added to the header seem to be necessary for CORS and the diff was supplied by @matheusd

Add purchaseTicketsV3 which purchases tickets using a watching only trezor wallet from a vsp with api v3. Errors if not on testnet. Add separate payVSPFee function that will pay a tickets fee if not already paid, and throws if already paid. Correct purchase ticket button for watching only wallets. It no longer asks for a password. Connect purchasing through trezor when isTrezor is true. Add vsp v3 endpoints "feeaddress" and "payfee" to allowed external requests. Change wallet/control.js to not require an unlocked wallet when signTx is false. Add headers to OPTIONS externalRequest. These are required by CORS when making POST requests.

JoeGruffins · 2022-06-24T09:44:07Z

Seeing a syncing issue after rebase. Looking into it...

Silly me, just needed to use a new dcrd. Looks fine.

There's some js errors I'm not sure I was seeing before, doesn't seem to affect the purchase, but going to put them here. Need to fix these?:

Refused to set unsafe header "origin"  browser-ponyfill.js:504

ControlActions.js:19 Uncaught (in promise) Error: 3 INVALID_ARGUMENT: wallet.NewExternalAddress: invalid operation: cannot use voting accounts for normal transactions

Warning: Each child in a list should have a unique "key" prop.              react_devtools_backend.js:6

Check the render method of `AccountsList`. See https://fb.me/react-warning-keys for more information.

react_devtools_backend.js:6 Warning: Failed prop type: The prop `toggled` is marked as required in `Toggle`, but its value is `undefined`.

bgptr · 2022-07-07T10:13:38Z

@JoeGruffins:

Refused to set unsafe header "origin"  browser-ponyfill.js:504

This seems to be related to

decrediton/app/main_dev/externalRequests.js

Lines 87 to 89 in 208195c

    
             details.requestHeaders["Origin"] = 
        
               "https://dummy-origin-to-fool-trezor-bridge.trezor.io"; 
        
           }

Without this, the communication to trezor does not work though. I think this warning doesn't need to fix, but probably @matheusd could correct me.

ControlActions.js:19 Uncaught (in promise) Error: 3 INVALID_ARGUMENT: wallet.NewExternalAddress: invalid operation: cannot use voting accounts for normal transactions

Warning: Each child in a list should have a unique "key" prop.              react_devtools_backend.js:6

Check the render method of `AccountsList`. See https://fb.me/react-warning-keys for more information.

I could not reproduce these warnings.

react_devtools_backend.js:6 Warning: Failed prop type: The prop `toggled` is marked as required in `Toggle`, but its value is `undefined`.

I fixed this in #3784. Thanks for the report.

alexlyp · 2022-11-22T20:37:35Z

Going to be closing this and the other PRs that have sat for quite some time. If you would like to re-open and start to move this PR towards completion, feel free to contact me and I can either reopen this or you may submit another.

JoeGruffins force-pushed the trezorstake branch 2 times, most recently from 21ae598 to b74dddb Compare November 18, 2020 03:50

JoeGruffins changed the title ~~multi: Allow ticket purchasing on trezor on testnet.~~ multi: Allow trezor ticket purchasing on testnet. Nov 18, 2020

JoeGruffins force-pushed the trezorstake branch from b74dddb to 7bff921 Compare November 18, 2020 04:32

JoeGruffins commented Nov 18, 2020

View reviewed changes

JoeGruffins marked this pull request as ready for review November 18, 2020 04:47

JoeGruffins commented Nov 18, 2020

View reviewed changes

app/actions/TrezorActions.js Outdated Show resolved Hide resolved

JoeGruffins force-pushed the trezorstake branch from 26acb57 to da2c01c Compare November 22, 2020 04:45

JoeGruffins commented Nov 25, 2020

View reviewed changes

matheusd reviewed Nov 27, 2020

View reviewed changes

JoeGruffins force-pushed the trezorstake branch from da2c01c to f2c984d Compare December 30, 2020 04:29

JoeGruffins force-pushed the trezorstake branch from 9a01a53 to 4029e18 Compare January 12, 2021 00:03

JoeGruffins force-pushed the trezorstake branch from 4029e18 to e57246d Compare January 19, 2021 08:49

JoeGruffins marked this pull request as draft March 24, 2021 08:50

JoeGruffins force-pushed the trezorstake branch 3 times, most recently from 675f7e5 to bf1b90b Compare March 26, 2021 03:59

JoeGruffins marked this pull request as ready for review March 26, 2021 05:08

JoeGruffins force-pushed the trezorstake branch from bf1b90b to 4ca3f2f Compare March 27, 2021 01:43

JoeGruffins force-pushed the trezorstake branch 3 times, most recently from c3f2f8c to 2609d15 Compare June 10, 2021 10:23

matheusd reviewed Jun 10, 2021

View reviewed changes

app/helpers/msgTx.js Outdated Show resolved Hide resolved

app/actions/TrezorActions.js Outdated Show resolved Hide resolved

app/actions/TrezorActions.js Show resolved Hide resolved

app/actions/TrezorActions.js Outdated Show resolved Hide resolved

JoeGruffins force-pushed the trezorstake branch from b5fefae to 27f14bb Compare June 11, 2021 06:41

matheusd reviewed Jun 11, 2021

View reviewed changes

app/actions/TrezorActions.js Outdated Show resolved Hide resolved

JoeGruffins mentioned this pull request Jun 16, 2021

trezorActions: Add votingXprivSeed. #3512

Closed

JoeGruffins force-pushed the trezorstake branch from 13c33f1 to cee2ef2 Compare August 10, 2021 04:08

JoeGruffins force-pushed the trezorstake branch from cee2ef2 to 19b92cb Compare August 30, 2021 07:34

JoeGruffins force-pushed the trezorstake branch from 19b92cb to 636b1df Compare September 21, 2021 05:25

JoeGruffins force-pushed the trezorstake branch 2 times, most recently from 74fa441 to de3c3ad Compare October 28, 2021 06:54

JoeGruffins force-pushed the trezorstake branch 2 times, most recently from bf951d2 to 014e931 Compare December 28, 2021 07:10

JoeGruffins mentioned this pull request Dec 28, 2021

trezor: Use upstream trezor connect. #3621

Merged

JoeGruffins force-pushed the trezorstake branch from 014e931 to 80b33e4 Compare December 30, 2021 01:48

JoeGruffins force-pushed the trezorstake branch 2 times, most recently from ce81796 to e13d88a Compare February 3, 2022 07:03

JoeGruffins force-pushed the trezorstake branch from e13d88a to 7c5eb84 Compare March 21, 2022 01:32

JoeGruffins force-pushed the trezorstake branch from 7c5eb84 to fa65df5 Compare June 24, 2022 09:16

JoeGruffins force-pushed the trezorstake branch from fa65df5 to b3ee94c Compare June 24, 2022 09:24

bgptr mentioned this pull request Jul 7, 2022

Fix js warning in ToggleSwitch component #3784

Merged

alexlyp closed this Nov 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

multi: Allow trezor ticket purchasing on testnet. #2869

multi: Allow trezor ticket purchasing on testnet. #2869

JoeGruffins commented Nov 6, 2020 •

edited

Loading

JoeGruffins left a comment

JoeGruffins Nov 18, 2020

JoeGruffins Nov 18, 2020

JoeGruffins Nov 18, 2020

JoeGruffins Nov 18, 2020

JoeGruffins commented Nov 18, 2020 •

edited

Loading

JoeGruffins commented Nov 19, 2020 •

edited

Loading

JoeGruffins commented Nov 20, 2020

JoeGruffins Nov 25, 2020

JoeGruffins Nov 25, 2020

JoeGruffins Nov 25, 2020

matheusd left a comment •

edited

Loading

JoeGruffins commented Mar 26, 2021

matheusd commented Mar 26, 2021

amass01 commented Mar 26, 2021

JoeGruffins commented Mar 26, 2021 •

edited

Loading

amass01 commented Mar 26, 2021

JoeGruffins commented Mar 27, 2021

JoeGruffins commented Jun 8, 2021 •

edited

Loading

matheusd left a comment

JoeGruffins commented Jul 7, 2021 •

edited

Loading

JoeGruffins commented Oct 28, 2021

JoeGruffins commented Jun 24, 2022 •

edited

Loading

bgptr commented Jul 7, 2022

alexlyp commented Nov 22, 2022

multi: Allow trezor ticket purchasing on testnet. #2869

multi: Allow trezor ticket purchasing on testnet. #2869

Conversation

JoeGruffins commented Nov 6, 2020 • edited Loading

JoeGruffins left a comment

Choose a reason for hiding this comment

JoeGruffins Nov 18, 2020

Choose a reason for hiding this comment

JoeGruffins Nov 18, 2020

Choose a reason for hiding this comment

JoeGruffins Nov 18, 2020

Choose a reason for hiding this comment

JoeGruffins Nov 18, 2020

Choose a reason for hiding this comment

JoeGruffins commented Nov 18, 2020 • edited Loading

JoeGruffins commented Nov 19, 2020 • edited Loading

JoeGruffins commented Nov 20, 2020

JoeGruffins Nov 25, 2020

Choose a reason for hiding this comment

JoeGruffins Nov 25, 2020

Choose a reason for hiding this comment

JoeGruffins Nov 25, 2020

Choose a reason for hiding this comment

matheusd left a comment • edited Loading

Choose a reason for hiding this comment

JoeGruffins commented Mar 26, 2021

matheusd commented Mar 26, 2021

amass01 commented Mar 26, 2021

JoeGruffins commented Mar 26, 2021 • edited Loading

amass01 commented Mar 26, 2021

JoeGruffins commented Mar 27, 2021

JoeGruffins commented Jun 8, 2021 • edited Loading

matheusd left a comment

Choose a reason for hiding this comment

JoeGruffins commented Jul 7, 2021 • edited Loading

JoeGruffins commented Oct 28, 2021

JoeGruffins commented Jun 24, 2022 • edited Loading

bgptr commented Jul 7, 2022

alexlyp commented Nov 22, 2022

JoeGruffins commented Nov 6, 2020 •

edited

Loading

JoeGruffins commented Nov 18, 2020 •

edited

Loading

JoeGruffins commented Nov 19, 2020 •

edited

Loading

matheusd left a comment •

edited

Loading

JoeGruffins commented Mar 26, 2021 •

edited

Loading

JoeGruffins commented Jun 8, 2021 •

edited

Loading

JoeGruffins commented Jul 7, 2021 •

edited

Loading

JoeGruffins commented Jun 24, 2022 •

edited

Loading