Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional statistics and charts #3205

Merged
merged 3 commits into from
Feb 16, 2021
Merged

Conversation

bgptr
Copy link
Collaborator

@bgptr bgptr commented Feb 5, 2021

This diff refactors staking statistics and charts components to functional component using hooks and CSS modules.

Part of #2439 and #2438
Closes #2989

Also, it improves their layout on small screens. Some before and after screenshots:

shot
shots2
shots3
shots4
shots5

Copy link
Member

@amass01 amass01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, added two minor inline comments & needs a rebase.

@alexlyp
Copy link
Member

alexlyp commented Feb 16, 2021

whoops the indicators module PR conflicted. sorry

@bgptr
Copy link
Collaborator Author

bgptr commented Feb 16, 2021

np 😀 resolved

@alexlyp alexlyp merged commit 9cf4468 into decred:master Feb 16, 2021
@bgptr bgptr deleted the functional-stat branch February 17, 2021 10:19
alexlyp pushed a commit that referenced this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning on ticket statistics
3 participants