Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[multi] Introduce preload script #3397

Merged
merged 7 commits into from
May 25, 2021
Merged

[multi] Introduce preload script #3397

merged 7 commits into from
May 25, 2021

Commits on May 25, 2021

  1. Switch from ipcRenderer.{on,send} to invoke 

    This makes the code cleaner in the ipc renderer side. ipcRenderer.invoke
implicitly returns a promise and doesn't block the ipcRenderer process
vs sendSync.
    @matheusd
    matheusd committed May 25, 2021
    Configuration menu
    Copy the full SHA
    714447a View commit details
    Browse the repository at this point in the history

  2. Switch statisticsAction to use fs through wallet module 

    This is a pre-requisite to moving fs accesses to a preload script.
    @matheusd
    matheusd committed May 25, 2021
    Configuration menu
    Copy the full SHA
    104663e View commit details
    Browse the repository at this point in the history

  3. Introduce preload script 

    This introduces a preload script to the app. This script is generated via
a new webpack config, which watches over changes to regenerate it as needed
when running via `yarn dev`.

Currently the only API reintroduced via this preload script into the main
world is the wallet/fs module. In future commits, other APIs will be
compatibilized to the preload script and will be offered through it.
    @matheusd
    matheusd committed May 25, 2021
    Configuration menu
    Copy the full SHA
    755ed50 View commit details
    Browse the repository at this point in the history

  4. Use preload script for fs ops in StatisticsActions 

    This serves as a check throughout development that the preload script is
behaving as expected.
    @matheusd
    matheusd committed May 25, 2021
    Configuration menu
    Copy the full SHA
    8d88287 View commit details
    Browse the repository at this point in the history

  5. Mock electron-store 

    This ensures tests pass.
    @matheusd
    matheusd committed May 25, 2021
    Configuration menu
    Copy the full SHA
    64c72dc View commit details
    Browse the repository at this point in the history

  6. Remove fs module from LN page

    @matheusd
    matheusd committed May 25, 2021
    Configuration menu
    Copy the full SHA
    de00a9d View commit details
    Browse the repository at this point in the history

  7. Switch LN actions to use invoke

    @matheusd
    matheusd committed May 25, 2021
    Configuration menu
    Copy the full SHA
    361d392 View commit details
    Browse the repository at this point in the history