-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Politeia: Migrate to new API. #3495
Conversation
5ea46ae
to
d052f75
Compare
Is the testnet Pi instance already updated and sufficient to test this or do we still need to run a local instance to test? |
hrmm looks like https://test-proposals.decred.org got some test data on it, maybe we can start vote on a proposal to test voting as well. |
Started one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got a "type error: cannot read property length of undefined" when loading the proposal on discussion in testnet (error page is looking nice, btw).
Accessing the proposal that is currently voting also occasionally fails. If I go to the "Finished Voting" tab, open a proposal, then go back to the "Voting" tab, the proposal opens. But if I then go to the "In Discussion" tab, try to open the proposal (this fails) and go back to the "Voting" tab, the under voting proposal will now not open.
I purchased tickets but I guess I didnt purchase them fast enough to be able to cast a vote on the prop, so I didnt test that.
@matheusd Fixed the in discussion edge case you were hitting. tested navigating to voting after visiting in discussion will be looking into the other issue with the voting prop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working fine (minus voting in active proposal which I couldn't test)
Closes #3391.
Note: The new API supports paginated vote inventory calls, I decided to keep the pagination work to a separate
future PR to try maintain incermental easily reviewable PRs.
Testing against local PI
To run against local PI instance add the following commented out code: