[electron] Remove winston as a dependency #3536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amass01
reviewed
Jul 21, 2021
app/main.development.js
Outdated
| ); | ||
|
|
||
| process.on("uncaughtException", (err) => { | ||
| logger.log("error", "UNCAUGHT EXCEPTION", err); | ||
| logger.log("error", "UNCAUGHT EXCEPTION: " + err); |
amass01
approved these changes
Jul 21, 2021
app/main_dev/launch.js
Outdated
| @@ -700,7 +700,7 @@ export const launchDCRWallet = async ( | |||
| e && | |||
| e.code && | |||
| e.code != "EOF" && | |||
| logger.log("error", "tx stream error", e) | |||
| logger.log("error", "tx stream error: " + e) | |||
app/main_dev/launch.js
Outdated
| @@ -873,7 +872,7 @@ export const launchDCRLnd = ( | |||
| if (!lastDcrdErr || lastDcrdErr === "") { | |||
| lastDcrdErr = lastPanicLine(GetDcrdLogs()); | |||
| } | |||
| logger.log("error", "dcrd closed due to an error: ", lastDcrdErr); | |||
| logger.log("error", "dcrd closed due to an error: " + lastDcrdErr); | |||
app/wallet/app.js
Outdated
| const logMsg = args.reduce((a) => a + "%s ", "%s "); | ||
| const logArgs = [msg, ...args.map(formatArg)]; | ||
| const logArgs = args.map(formatArg); | ||
| const logMsg = msg + " " + logArgs.join(" "); |
bgptr
requested changes
Jul 21, 2021
There was a problem hiding this comment.
The code looks good and works fine.
I found only one critical issue: when I try to navigate to Logs view the application quits with this error message:
/home/bgptr/go/src/github.com/decred/decrediton/app/main.js:729
_fs.default.existsSync(walletsDirectory)||_fs.default.mkdirSync(walletsDirectory,{recursive:true});_fs.default.existsSync(mainnetWalletsPath)||_fs.default.mkdirSync(mainnetWalletsPath,{recursive:true});_fs.default.existsSync(testnetWalletsPath)||_fs.default.mkdirSync(testnetWalletsPath,{recursive:true});(0,_paths.checkAndInitWalletCfg)(true);(0,_paths.checkAndInitWalletCfg)(false);logger.log("info","Using config/data from:"+_electron.app.getPath("userData"));logger.log("info",`Versions: Decrediton: ${_electron.app.getVersion()}, `+`Electron: ${process.versions.electron}, `+`Chrome: ${process.versions.chrome}`);process.on("uncaughtException",err=>{logger.log("error",`UNCAUGHT EXCEPTION: ${err}`);throw err;});const installExtensions=async()=>{if(true){const extensions=[_electronDevtoolsInstaller.REACT_DEVELOPER_TOOLS,_electronDevtoolsInstaller.REDUX_DEVTOOLS];const forceDownload=!!process.env.UPGRADE_EXTENSIONS;for(const name of extensions){try{await(0,_electronDevtoolsInstaller.default)(name,forceDownload);}catch(e){console.log("Error installing extension: "+e);}}}};const{ipcMain}=__webpack_require__(/*! electron */"electron");// handleEvent listens on the given channel for ipcRenderer.invoke() calls and
^
TypeError: Cannot read property 'find' of undefined
at IpcMainImpl.<anonymous> (/home/bgptr/go/src/github.com/decred/decrediton/app/main.js:8821:42)
at IpcMainImpl.emit (events.js:315:20)
at Object.<anonymous> (electron/js2c/browser_init.js:161:10351)
at Object.emit (events.js:315:20)
|
Nice catch! Updated. |
bgptr
approved these changes
Jul 22, 2021
alexlyp
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the winston log library as a dependency from the project. This helps reduce the number of dependencies on the main electron layer.
This is done by implementing a very basic logger that replicates the features we were using from winston: writing both to a log file and to the terminal when
debugis set.Dependencies of the main electron layer before winston is removed:
After removing winston:
