multi: Remove staking from hw wallet menus. #3870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JoeGruffins
force-pushed
the
hardwareremovestakingscreenandwarning
branch
2 times, most recently
from
0b52cbd
to
013f88d
Compare
Staking does not currently work for hardware wallets. Remove the screens and options that have to do with staking for now to avoid confusion. Hardware wallets also cannot currently handle stake inputs when signing. Add a warning to receiving screens not to use addresses for staking or treasury receives.
JoeGruffins
force-pushed
the
hardwareremovestakingscreenandwarning
branch
from
013f88d
to
19d2e1a
Compare
|
Name tag parts. Also added "Caution!" to the warning https://github.com/decred/decrediton/compare/013f88d3b49d26ecd39b6d4e2575496bc687224e..19d2e1ae01947955059680ffc1fb8db1d2a72b20 |
alexlyp
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staking does not currently work for hardware wallets. Remove the screens and options that have to do with staking for now to avoid confusion. Hardware wallets also cannot currently handle stake inputs when signing. Add a warning to receiving screens not to use addresses for staking or treasury receives.
Part of #3865