fix build on 32-bit platforms and properly error on too small worksizes #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't care too much about 32bit builds (I'd actually prefer to not provide/support 32bit at all) but this looks more correct than what we had before. And works fine when I test. tACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on 32-bit platforms doesn't work due to the untyped maxWorkSize constant:
./config.go:39: constant 4294967295 overflows int
This types it properly so it builds and runs. I also set it to a value that is divisible by 256 with no remainder so if someone hits the error, they can just plug in the value from the error string.
I also fixed it to catch -W 0 since I noticed that wasn't caught properly during my testing.