use nvml to fetch fan and temperature information #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason you added the nvml-go files rather than importing it (and adding to glide) from whereever the upstream is. Other than that it seems to work with no issues or performance regressions for me. |
|
I did it primarily since it makes it easier to adjust the default CGO_CFLAGS/CGO_LDFLAGS to something sensible which will be useful whenever Windows is building properly. |
|
Makes sense. Could you add the url for the upstream repo to the commit message in case we want to update it or switch to upstream at some point? |
Adds https://github.com/abduld/nvml-go/ with some minor modifications.
|
Done. |
|
OK (once travis is done). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial NVML support. It could go into the OpenCL path too but I don't think that makes sense. Plus I'd rather not make building messier than it already is until #83 happens.
Might want to add an nvml.Shutdown() after all the devices are released down the road but it doesn't seem to matter in practice.
Doesn't seem to affect performance either.
Closes #63.