Add a config file #6
Conversation
config.go
Outdated
| type config struct { | ||
| LndIP string `long:"lnd_ip" description:"the public IP address of the faucet's node"` | ||
| NetParams string `long:"net" description:"decred network to operate on"` | ||
| LndNodes string `long:"nodes" description:"comma separated list of host:port"` |
There was a problem hiding this comment.
It's not true that we support multiple nodes via a comma separated list. Only a single node is connected to, and I'm not sure it's even worth adding multi-node support given we already have 3 independent faucets running...
config.go
Outdated
| "path/filepath" | ||
| "strings" | ||
|
|
||
| "github.com/btcsuite/go-flags" |
There was a problem hiding this comment.
You should change this to "github.com/jessevdk/go-flags" to be consistent with other tools.
config.go
Outdated
| func loadConfig() (*config, []string, error) { | ||
| // Default config. | ||
| cfg := config{ | ||
| LndIP: defaultLndIP, |
There was a problem hiding this comment.
This isn't being used anywhere, so I believe it's safe to remove. We're using the address returned by the NodeInfo call to the node, which is more reliable anyway.
config.go
Outdated
| defaultBindAddr = ":80" | ||
| defaultUseLeHTTPS = false | ||
| defaultWipeChannels = false | ||
| defaultDomain = "faucet.lightning.community" |
There was a problem hiding this comment.
It's probably better to not specify a default for the domain and check whether it is specified when -use_le_https is used.
sample-dcrlnfaucet.conf
Outdated
|
|
||
| ; network is the network the faucet is running on. This value must | ||
| ; either be "litecoin" or "bitcoin". | ||
| network=decred |
There was a problem hiding this comment.
Unnecessary, since this is decred only and our UI is for tailored for dcr.
Rebased on top of #5