Add proposal billing list max page size

decred · Jul 23, 2020 · 115e746 · 115e746
1 parent 8c0f859
commit 115e746
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/politeiawww/api/cms/v1/v1.go b/politeiawww/api/cms/v1/v1.go
@@ -176,6 +176,11 @@ const (
 	// statement contained within a DCC
 	PolicyMaxSponsorStatementLength = 5000
 
+	// ProposalBillingListPageSize is the maximum number of proposal billing
+	// summaries returned for the routes that return lists of proposal billing
+	// summaries.
+	ProposalBillingListPageSize = 50
+
 	ErrorStatusMalformedName                  www.ErrorStatusT = 1001
 	ErrorStatusMalformedLocation              www.ErrorStatusT = 1002
 	ErrorStatusInvoiceNotFound                www.ErrorStatusT = 1003

diff --git a/politeiawww/invoices.go b/politeiawww/invoices.go
@@ -1802,6 +1802,12 @@ func (p *politeiawww) processProposalBillingSummary(pbs cms.ProposalBillingSumma
 	}
 
 	approvedProposals := tvr.Approved
+
+	count := pbs.Count
+	if count > cms.ProposalBillingListPageSize {
+		count = cms.ProposalBillingListPageSize
+	}
+
 	proposalInvoices := make(map[string][]*database.Invoice, len(approvedProposals))
 	for i, prop := range approvedProposals {
 		if i < pbs.Offset {
@@ -1817,10 +1823,11 @@ func (p *politeiawww) processProposalBillingSummary(pbs cms.ProposalBillingSumma
 			proposalInvoices[prop] = make([]*database.Invoice, 0)
 		}
 
-		if pbs.Count != 0 && len(proposalInvoices) >= pbs.Count {
+		if count != 0 && len(proposalInvoices) >= count {
 			break
 		}
 	}
+
 	spendingSummaries := make([]cms.ProposalSpending, 0, len(proposalInvoices))
 	for prop, invoices := range proposalInvoices {
 		spendingSummary := cms.ProposalSpending{}